Skip to content

Commit

Permalink
Fix/testing oed4 update (#1160)
Browse files Browse the repository at this point in the history 
* update test_analysis_model

* fix test_portfolio

* pep
  • Loading branch information
@sambles
sambles authored Jan 28, 2025
1 parent 9e7e7c4 commit 445c394
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 20 deletions.
15 changes: 8 additions & 7 deletions src/server/oasisapi/analysis_models/v1_api/tests/test_analysis_model.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,14 @@ def test_settings_json_is_not_valid___response_is_400(self):
)

validation_error = {
'model_settings': ["Additional properties are not allowed ('float_parameter' was unexpected)"],
'model_settings-event_set': ["'desc' is a required property"],
'model_settings-event_occurrence_id-default': ["1 is not of type 'string'"],
'model_settings-boolean_parameters-0-default': ["1.1 is not of type 'boolean'"],
'lookup_settings-supported_perils-0': ["Additional properties are not allowed ('i' was unexpected)", "'id' is a required property"],
'lookup_settings-supported_perils-1': ["Additional properties are not allowed ('des' was unexpected)", "'desc' is a required property"],
'lookup_settings-supported_perils-2-id': ["'WW11' is too long"]
"model_settings-boolean_parameters-0-default": ["1.1 is not of type 'boolean'"],
"model_settings-event_set": ["'desc' is a required property"],
"model_settings-event_occurrence_id-default": ["1 is not of type 'string'"],
"lookup_settings-supported_perils-0": ["Additional properties are not allowed ('i' was unexpected)",
"'id' is a required property"],
"lookup_settings-supported_perils-1": ["Additional properties are not allowed ('des' was unexpected)",
"'desc' is a required property"],
"lookup_settings-supported_perils-2-id": ["'WW11' is too long"]
}

self.assertEqual(400, response.status_code)
Expand Down
15 changes: 8 additions & 7 deletions src/server/oasisapi/analysis_models/v2_api/tests/test_analysis_model.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -365,13 +365,14 @@ def test_settings_json_is_not_valid___response_is_400(self):
)

validation_error = {
'model_settings': ["Additional properties are not allowed ('float_parameter' was unexpected)"],
'model_settings-event_set': ["'desc' is a required property"],
'model_settings-event_occurrence_id-default': ["1 is not of type 'string'"],
'model_settings-boolean_parameters-0-default': ["1.1 is not of type 'boolean'"],
'lookup_settings-supported_perils-0': ["Additional properties are not allowed ('i' was unexpected)", "'id' is a required property"],
'lookup_settings-supported_perils-1': ["Additional properties are not allowed ('des' was unexpected)", "'desc' is a required property"],
'lookup_settings-supported_perils-2-id': ["'WW11' is too long"]
"model_settings-boolean_parameters-0-default": ["1.1 is not of type 'boolean'"],
"model_settings-event_set": ["'desc' is a required property"],
"model_settings-event_occurrence_id-default": ["1 is not of type 'string'"],
"lookup_settings-supported_perils-0": ["Additional properties are not allowed ('i' was unexpected)",
"'id' is a required property"],
"lookup_settings-supported_perils-1": ["Additional properties are not allowed ('des' was unexpected)",
"'desc' is a required property"],
"lookup_settings-supported_perils-2-id": ["'WW11' is too long"]
}

self.assertEqual(400, response.status_code)
Expand Down
3 changes: 0 additions & 3 deletions src/server/oasisapi/portfolios/v1_api/tests/test_portfolio.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1190,11 +1190,8 @@ def test_account_file__is_invalid__response_is_400(self):
['account', "column 'LocNumber' is not a valid oed field"],
['account', "column 'IsTenant' is not a valid oed field"],
['account', "column 'BuildingID' is not a valid oed field"],
['account', "column 'CountryCode' is not a valid oed field"],
['account', "column 'Latitude' is not a valid oed field"],
['account', "column 'Longitude' is not a valid oed field"],
['account', "column 'StreetAddress' is not a valid oed field"],
['account', "column 'PostalCode' is not a valid oed field"],
['account', "column 'OccupancyCode' is not a valid oed field"],
['account', "column 'ConstructionCode' is not a valid oed field"],
['account', "column 'LocPerilsCovered' is not a valid oed field"],
Expand Down
3 changes: 0 additions & 3 deletions src/server/oasisapi/portfolios/v2_api/tests/test_portfolio.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1434,11 +1434,8 @@ def test_account_file__is_invalid__response_is_400(self):
['account', "column 'LocNumber' is not a valid oed field"],
['account', "column 'IsTenant' is not a valid oed field"],
['account', "column 'BuildingID' is not a valid oed field"],
['account', "column 'CountryCode' is not a valid oed field"],
['account', "column 'Latitude' is not a valid oed field"],
['account', "column 'Longitude' is not a valid oed field"],
['account', "column 'StreetAddress' is not a valid oed field"],
['account', "column 'PostalCode' is not a valid oed field"],
['account', "column 'OccupancyCode' is not a valid oed field"],
['account', "column 'ConstructionCode' is not a valid oed field"],
['account', "column 'LocPerilsCovered' is not a valid oed field"],
Expand Down

0 comments on commit 445c394

Please sign in to comment.