Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use minimal quoting for all csv files #227

Closed
wants to merge 2 commits into from
Closed

Use minimal quoting for all csv files #227

wants to merge 2 commits into from

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Oct 31, 2024

Use minimal quoting for all csv files

@sambles sambles requested review from johcarter and sstruzik October 31, 2024 09:13
@github-actions GitHub Actions
Copy link

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit ac248a0
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11609132442
Excel File excel_spec.zip
JSON File extracted_spec.zip

johcarter
johcarter reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@johcarter johcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep consistent double quotes everywhere as it is harder to make a formatting mistake when editing.

@sambles sambles closed this Nov 28, 2024
@sambles sambles deleted the oed4/use_csv_minimal_quoting branch November 28, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johcarter johcarter johcarter left review comments

@sstruzik sstruzik Awaiting requested review from sstruzik

Assignees
No one assigned
Labels
None yet
Projects
Oasis Dev Team Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sambles @johcarter