Fix Weak Encryption Demos #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and add best practices
…modes and enhance security context
…ests for more info in the evaluation.
…yption algorithms
… to redirect output correctly
…hing and simplify summary
…gorithm description and reference for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request:
Best Practices
best-practices/MASTG-BEST-0009.md: Added a new best practice guideline recommending the use of secure encryption algorithms such as AES-256 and Chacha20.Demo Content
demos/android/MASVS-CRYPTO/MASTG-DEMO-0023/MASTG-DEMO-0022.md: Updated demo title and content.demos/android/MASVS-CRYPTO/MASTG-DEMO-0023/MASTG-DEMO-0023.md: Added a new demo for detecting insecure encryption modes using Semgrep.Demo Code:
demos/android/MASVS-CRYPTO/MASTG-DEMO-0022/MastgTest.kt: Updated the demo code to use secure key generation for DES, 3DES, RC4, and Blowfish encryption algorithms.Semgrep Rules:
rules/mastg-android-weak-encryption-algorithms.yaml: Enhanced the rule to detect additional weak encryption algorithms including RC4 and Blowfish.rules/mastg-android-weak-encryption-modes.yaml: Enhanced the rule to use a regex pattern for detecting weak encryption modes such as AES-ECB.