Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MASWE-0117 - Inadequate Permission Management (by @NowSecure) #3119

Merged
merged 7 commits into from
Feb 14, 2025

Conversation

cpholguera
Copy link
Collaborator

Closes #3117

@cpholguera cpholguera changed the title Add-maswe-0117 Add MASWE-0117 - Inadequate Permission Management Jan 17, 2025
@cpholguera cpholguera requested a review from sushi2k January 17, 2025 10:33
Copy link
Collaborator

@sushi2k sushi2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments. Otherwise it's a great summary of the weakness.

refs:
- https://developer.apple.com/design/human-interface-guidelines/privacy#Requesting-permission
- https://developer.apple.com/documentation/uikit/protecting_the_user_s_privacy/requesting_access_to_protected_resources
- https://developer.android.com/training/permissions/requesting#explain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these URLs with the anchor, as we anyway are referencing to the main page (https://developer.android.com/training/permissions/requesting)

- https://support.google.com/googleplay/android-developer/answer/9888170?hl=en
- https://developer.android.com/privacy-and-security/minimize-permission-requests
- https://developer.android.com/training/permissions/requesting
- https://developer.android.com/training/permissions/requesting#remove-access
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these URLs with the anchor, as we anyway are referencing to the main page (https://developer.android.com/training/permissions/requesting)

- https://developer.android.com/training/permissions/usage-notes
- https://arxiv.org/pdf/1905.02713
- https://arxiv.org/pdf/2203.10583
-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-

weaknesses/MASVS-PRIVACY/MASWE-0117.md Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0117.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0117.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0117.md Outdated Show resolved Hide resolved
weaknesses/MASVS-PRIVACY/MASWE-0117.md Outdated Show resolved Hide resolved
@cpholguera cpholguera requested a review from sushi2k January 21, 2025 10:57
@cpholguera cpholguera merged commit a9f4a3b into master Feb 14, 2025
3 checks passed
@cpholguera cpholguera deleted the add-maswe-0117 branch February 14, 2025 10:17
@cpholguera cpholguera changed the title Add MASWE-0117 - Inadequate Permission Management Add MASWE-0117 - Inadequate Permission Management (by @NowSecure) Feb 14, 2025
titze pushed a commit to titze/owasp-mastg that referenced this pull request Feb 18, 2025
* Add MASWE-0117: Inadequate Permission Management

* Update CWE reference for MASWE-0117 from 359 to 250

* Remove duplicate Android permission request references in MASWE-0117

* Clarify permission management risks and add new references

* fix missing white space

* Update weaknesses/MASVS-PRIVACY/MASWE-0117.md

* Update weaknesses/MASVS-PRIVACY/MASWE-0117.md

Co-authored-by: Jeroen Beckers <[email protected]>

---------

Co-authored-by: Jeroen Beckers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MASWE-0117] New MASWE Weakness: Inadequate Permission Management
3 participants