-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MASWE-0117 - Inadequate Permission Management (by @NowSecure) #3119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments. Otherwise it's a great summary of the weakness.
refs: | ||
- https://developer.apple.com/design/human-interface-guidelines/privacy#Requesting-permission | ||
- https://developer.apple.com/documentation/uikit/protecting_the_user_s_privacy/requesting_access_to_protected_resources | ||
- https://developer.android.com/training/permissions/requesting#explain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these URLs with the anchor, as we anyway are referencing to the main page (https://developer.android.com/training/permissions/requesting)
- https://support.google.com/googleplay/android-developer/answer/9888170?hl=en | ||
- https://developer.android.com/privacy-and-security/minimize-permission-requests | ||
- https://developer.android.com/training/permissions/requesting | ||
- https://developer.android.com/training/permissions/requesting#remove-access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these URLs with the anchor, as we anyway are referencing to the main page (https://developer.android.com/training/permissions/requesting)
- https://developer.android.com/training/permissions/usage-notes | ||
- https://arxiv.org/pdf/1905.02713 | ||
- https://arxiv.org/pdf/2203.10583 | ||
- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- |
Co-authored-by: Jeroen Beckers <[email protected]>
* Add MASWE-0117: Inadequate Permission Management * Update CWE reference for MASWE-0117 from 359 to 250 * Remove duplicate Android permission request references in MASWE-0117 * Clarify permission management risks and add new references * fix missing white space * Update weaknesses/MASVS-PRIVACY/MASWE-0117.md * Update weaknesses/MASVS-PRIVACY/MASWE-0117.md Co-authored-by: Jeroen Beckers <[email protected]> --------- Co-authored-by: Jeroen Beckers <[email protected]>
Closes #3117