Buttons tooltips anchor tags migration to chakraUI #715

Dishant1804 · 2025-02-02T17:24:53Z

Resolves #645

Migrated all the tooltips, buttons and anchor tags to equivalent chakraUI components

Dishant1804 · 2025-02-02T17:28:57Z

@arkid15r I've migrated the necessary components mentioned in the issue. Please review it and let me know if any changes are required :)

kasya

Overall great migration! Thank you for updating these!

One issue I noticed:
in the light mode when some buttons in focus state now have this dark border (that is also kind of a pixel off the actual border 🤔 ). Can we get rid of this?

I found two instances of this, but there might be more. Ones that I found are on the User details page and on the issue details modal.

Dishant1804 · 2025-02-03T02:59:31Z

Overall great migration! Thank you for updating these!

One issue I noticed:
in the light mode when some buttons in focus state now have this dark border (that is also kind of a pixel off the actual border 🤔 ). Can we get rid of this?

I found two instances of this, but there might be more. Ones that I found are on the User details page and on the issue details modal.

Yess @kasya thank you for suggesting the changes, I'll go to the root of this issue, but for now it seems like the default chakraUI button recipe is causing this focus ring effect, I'll fix that :)

harsh3dev

LGTM
Please take care of conflicts and comments from other reviewers.
Thanks

* base_design * Add types and apply corrections. * Improvement * cleanup * added issue label * fixes * pre-commit --------- Co-authored-by: Kate Golovanova <[email protected]>

* Addition of Contribute Section in Home of Slack NestBot * Update contribute.py * Update of apps/slack/commands/contribute * Minor changes * Update of code after the review * Update backend/apps/slack/commands/contribute.py Co-authored-by: Nitin Awari <[email protected]> * Update urls.py * Update contribute.py * Update code --------- Co-authored-by: Nitin Awari <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>

…chor_migration

frontend/src/components/SortBy.tsx

Dishant1804 · 2025-02-03T08:16:29Z

Overall great migration! Thank you for updating these!

One issue I noticed: in the light mode when some buttons in focus state now have this dark border (that is also kind of a pixel off the actual border 🤔 ). Can we get rid of this?

I found two instances of this, but there might be more. Ones that I found are on the User details page and on the issue details modal.

@kasya I've made the suggested changes now there is no focus rings on the mentioned buttons, please review it :)

Dishant1804 · 2025-02-04T04:39:57Z

@kasya @Rajgupta36 @arkid15r I've made all the changes suggested by the reviewers, please let me know if we need more changes (if any) :)

Dishant1804 · 2025-02-04T05:22:33Z

This error appears in both normal and incognito modes. Can anyone verify it, please?

@Rajgupta36 i went deep into this issue and researched about it, here's what i found out:

The deprecation error we are encountering is due to the browser, the browsers now expect the libraries to use :state(bg-currentcolor) instead of --bg-currentcolor syntax.
The deprecation will be solved once the chakraUI library migrates their internal implementation
Also people using various libraries are facing the same issue we can check out reference here , here and here
Devs at chakraUI have already started working on it we can check it here

The deprecation will be automatically resolved in upcoming version changes of chakraUI, correct me if i am wrong. I've just presented what i researched about

arkid15r · 2025-02-06T18:32:14Z

@Dishant1804 my understanding we can merge this after resolving the conflicts?

* Addition of website attribute to project schema * Update vite.config.ts * Update website-empty.yaml * Update website-none.yaml * Update website-none.yaml * Update website-empty.yaml * Update website-none.yaml * Update website-empty.yaml * Update website-empty.yaml * Update project_test.py * Update project.json * Delete schema/tests/data/project/negative/website-empty.yaml * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>

* added blog attribute to project schema * added blog attribute * Update project_test.py * Update code * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>

* Changes5 * Refactor index synonyms * Update code --------- Co-authored-by: Raghav Gupta 2 <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>

* write repository schema and tests * fixed repository schema tests * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>

* gsoc command data fetch from algolia * pre-commit and format checks * moved get_gsoc_projects to search project file * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>

Bumps [@chakra-ui/react](https://github.com/chakra-ui/chakra-ui/tree/HEAD/packages/react) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/chakra-ui/chakra-ui/releases) - [Changelog](https://github.com/chakra-ui/chakra-ui/blob/main/packages/react/CHANGELOG.md) - [Commits](https://github.com/chakra-ui/chakra-ui/commits/@chakra-ui/[email protected]/packages/react) --- updated-dependencies: - dependency-name: "@chakra-ui/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added a method to convert block to text * Added testcase for utils * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>

* "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * "Cleanup: removing unused dependencies n dev dependencies " * resolved conflicts * Fix staging image build * "Cleanup: removing unused dependencies n dev dependencies " * fix run npm install install prettier plugin tailwindcss * fix run run npm lint check * fix check for uncommited changes * resolved conflicts n npm format check * updated one * updated fix * removed unwanted files from updated fix * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>

Dishant1804 · 2025-02-07T04:49:53Z

@arkid15r i've resolved the conflicts please merge it :)

arkid15r

LGTM 👍

Resolved.

Dishant1804 added 3 commits February 2, 2025 22:15

anchor tags migrated

a374063

Buttons migrated to chakraUI

a862813

migarted buttons tooltip and anchortags to chakraUI

175e015

Dishant1804 requested review from arkid15r and kasya as code owners February 2, 2025 17:24

github-actions bot added frontend frontend-tests labels Feb 2, 2025

Dishant1804 changed the title ~~Buttons tooltips anchor migration~~ Buttons tooltips anchor tags migration to chakraUI Feb 2, 2025

arkid15r requested review from aramattamara, harsh3dev, abhayymishraa, Rajgupta36 and kayashth1 February 2, 2025 18:52

Merge branch 'main' into buttons_tooltips_anchor_migration

c8fba15

github-actions bot added the schema label Feb 3, 2025

kasya previously requested changes Feb 3, 2025

View reviewed changes

harsh3dev approved these changes Feb 3, 2025

View reviewed changes

abhayymishraa approved these changes Feb 3, 2025

View reviewed changes

Dishant1804 and others added 5 commits February 3, 2025 12:21

fixed focus ring issue

7fbbbae

Generic component for details page (OWASP#678)

01fa7cd

* base_design * Add types and apply corrections. * Improvement * cleanup * added issue label * fixes * pre-commit --------- Co-authored-by: Kate Golovanova <[email protected]>

Merge remote-tracking branch 'upstream/main' into buttons_tooltips_an…

df9a32a

…chor_migration

resolved conflicts

55790b6

kayashth1 suggested changes Feb 3, 2025

View reviewed changes

frontend/src/components/SortBy.tsx Outdated Show resolved Hide resolved

sort dropdown tooltip position modified

59c1bec

kayashth1 approved these changes Feb 3, 2025

View reviewed changes

Dishant1804 requested a review from kasya February 3, 2025 08:14

removed redundant lines

b173dcc

Merge branch 'main' into buttons_tooltips_anchor_migration

66fb973

arkid15r and others added 17 commits February 7, 2025 10:12

Update FE dependencies

f86df8e

tooltip-bug (OWASP#744)

0f85a20

Add blog to project schema (OWASP#745)

f416610

* added blog attribute to project schema * added blog attribute * Update project_test.py * Update code * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>

Initialize OWASP chapter schema

4e903a0

Refactor index synonyms (OWASP#748)

00dc202

* Changes5 * Refactor index synonyms * Update code --------- Co-authored-by: Raghav Gupta 2 <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>

write repository schema and tests (OWASP#741)

b16e3e7

* write repository schema and tests * fixed repository schema tests * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>

Reconfigure spell check

cb2dc82

Update params mapping

af3515e

Added a method to convert block to text and fixed warning (OWASP#754)

f6860b6

* Added a method to convert block to text * Added testcase for utils * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>

Update frontend dependencies

477da90

Run poetry update

962c21f

conflicts resolved

68f2b2a

conflicts resolved

6d0ddf2

arkid15r approved these changes Feb 7, 2025

View reviewed changes

arkid15r enabled auto-merge February 7, 2025 05:52

arkid15r added this pull request to the merge queue Feb 7, 2025

Merged via the queue into OWASP:main with commit 0c297be Feb 7, 2025
13 checks passed

kayashth1 mentioned this pull request Feb 10, 2025

PR reviews 2025 #395

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buttons tooltips anchor tags migration to chakraUI #715

Buttons tooltips anchor tags migration to chakraUI #715

Dishant1804 commented Feb 2, 2025 •

edited

Loading

Dishant1804 commented Feb 2, 2025

kasya left a comment

Dishant1804 commented Feb 3, 2025

harsh3dev left a comment

Dishant1804 commented Feb 3, 2025

Dishant1804 commented Feb 4, 2025

Dishant1804 commented Feb 4, 2025 •

edited

Loading

arkid15r commented Feb 6, 2025

Dishant1804 commented Feb 7, 2025

arkid15r left a comment

Buttons tooltips anchor tags migration to chakraUI #715

Buttons tooltips anchor tags migration to chakraUI #715

Conversation

Dishant1804 commented Feb 2, 2025 • edited Loading

Dishant1804 commented Feb 2, 2025

kasya left a comment

Choose a reason for hiding this comment

Dishant1804 commented Feb 3, 2025

harsh3dev left a comment

Choose a reason for hiding this comment

Dishant1804 commented Feb 3, 2025

Dishant1804 commented Feb 4, 2025

Dishant1804 commented Feb 4, 2025 • edited Loading

arkid15r commented Feb 6, 2025

Dishant1804 commented Feb 7, 2025

arkid15r left a comment

Choose a reason for hiding this comment

Dishant1804 commented Feb 2, 2025 •

edited

Loading

Dishant1804 commented Feb 4, 2025 •

edited

Loading