Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pagination logic in the slack bot #489

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

abhayymishraa
Copy link
Collaborator

Resolves #341

Add the PR description here.
This pr added the pagination logic for the slackbot Home Section
Screenshot from 2025-01-15 18-27-22
Screenshot from 2025-01-15 18-27-01
Screenshot from 2025-01-15 18-26-41

@abhayymishraa abhayymishraa marked this pull request as ready for review January 15, 2025 20:55
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, here is some initial feedback:

backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
@abhayymishraa
Copy link
Collaborator Author

I think now it's all messed up because of that merge

backend/apps/owasp/api/search/chapter.py Outdated Show resolved Hide resolved
backend/apps/slack/actions/home.py Outdated Show resolved Hide resolved
backend/apps/slack/blocks.py Outdated Show resolved Hide resolved
backend/apps/slack/blocks.py Outdated Show resolved Hide resolved
backend/apps/slack/commands/committees.py Outdated Show resolved Hide resolved
backend/apps/slack/common/handlers/committees.py Outdated Show resolved Hide resolved
@arkid15r arkid15r enabled auto-merge January 20, 2025 03:03
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Jan 20, 2025
Merged via the queue into OWASP:main with commit 6cca7a9 Jan 20, 2025
13 checks passed
@abhayymishraa
Copy link
Collaborator Author

Thank You @arkid15r :)

@abhayymishraa abhayymishraa deleted the slack/pagination branch January 20, 2025 20:18
bhagyashree980 pushed a commit to bhagyashree980/Nest that referenced this pull request Jan 23, 2025
* Added pagination logic in the slack bot

* pre-commit

* chhnages after conflit and new chnages

* fixed bug: do not append a blank button

* resolved issues

* Update code

---------

Co-authored-by: Arkadii Yakovets <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement NestBot pagination logic
2 participants