Powerplant data functions #198
Conversation
-Split the 'main' in powerplant_data into individual functions to improve readability and the ease of debugging.
-Split in functions -Transmission not yet separated -User config still part of the script
|
@trevorb1 I've finished the refactoring of the powerplant script which on my end is now functional both standalone from main as well as by running the full workflow. If you have time could you do a review at this point? Note that I've moved the configurable variables to support the standalone functioning of the set of scripts from |
There was a problem hiding this comment.
Thanks for getting a start on this @maartenbrinkerink! Maybe we can discuss in person tomorrow, but this can not be merged until the snakemake/globals issue is resolved.
I have some thoughts about how to address this issue and will launch a draft PR that builds off this to get your thoughts.
workflow/scripts/osemosys_global/powerplant/residual_capacity.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/costs_transmission.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/residual_capacity.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/user_defined_capacity.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/user_defined_capacity.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/user_defined_capacity.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/powerplant/user_defined_capacity.py
Outdated
Show resolved
Hide resolved
workflow/scripts/osemosys_global/transmission/user_defined_capacity.py
Outdated
Show resolved
Hide resolved
Powerplant file check patch
-Updates following @trevorb1 PR review comments -Fixed user defined IAR bug following user defined capacities for transmission -Added comment in main scripts that config variables defined locally are for testing purposes only -Compared results to master which are in line with small differences possibly as a result of the changes in the config file (user defined capacities separated for transmission and powerplants)
Description
Large overhaul of the powerplant_data script by splitting 'main' in individual functions as it was incredibly difficult to navigate and problem solve. Have not yet separated transmission from the powerplant_data script (next step).
Issue Ticket Number
Documentation