Feature/image processing class #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pixel_values publisher takes care of those 3 scripts The scripts are now moved to the 'trash' folder
- Added image detection code to auto check if the input image is RGB, GrayScale or Binary - Currently Arduino Lights are not turning on. ROBOT motion works
- Tried re-plugging the cable - Tried removing the image correction code, tried remvoing the pub_handle parameter in the class - Checked the rostopic echo & msgs are publishing fine & the values are correct - Tried removing delays. Still nothing - RGB LED works fine if you run it with other code
- Only need to use "No Descartes Robot Motion" Script to move robot & detect images Scripts to use: - No_Descartes_Robot_Motion.py - image_inputs.py - pixel_value_publisher.py
- removed unused lines - added comments for lines
|
Looks good. I'll resolve merge conflicts and merge PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts to use: