Feature/grayscale #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleaned up scripts & added ReadMe file - Had to change Binary script to use ROS Publisher because the serial connection messed with the ROS Launch Arduino connection. (Created custom msg file) - Moved py_to_ino scipts to test folder. These files are used to test the arduino connection via python - Robot_motion script is the Action Client to the descartes Action Server branch - Currently getting error: [ERROR] [1649688048.164270]: Error opening serial: [Errno 2] could not open port -port=/tty/ACM0: [Errno 2] No such file or directory: '-port=/tty/ACM0'
- Created GrayScale script for future use - Same issue persisting with Arduino-ROS connection - ERROR: Unable to sync with device; possible link problem or link software version mismatch such as hydro rosserial_python with groovy Arduino - GrayScale will be made into a separate branch. The following commits will be about the Arduino-ROS connection
- Fixed Arduino sketchbook location. - Need to create the ROS Arduino scripts for Graycale & Binary.
-Linear time scale + dimming from LED resulted in a bright pixels overall in exposure shot -added 8x5 ramp tif -ts_led_paintbrush launch doesn't seem needed anymore?
- Created variable time delays based on pixel values - Diffusing light with paper may work to create gradient. Need thicker paper to remove bright point.
- Used a linear scaling factor to change time delay based on pixel value - Gradient is best seen on large images (5x5 or greater)
- Leading LED on is no different than adding delays because of the dimmness of the LED - Dimness of the LED shows the bulb in each movement instead of a continuous streak Would have to reduce resistance to get continuous streak
- need to see pixel values of grayscale image to get lumosity - Next add Diffuser to LED & reduce resistance - Create action client for Descartes implementation
acbuynak
approved these changes
Apr 15, 2022
Comment on lines
+19
to
+20
| BinaryState.msg | ||
| GrayScale.msg |
There was a problem hiding this comment.
Do we need both a grayscale and a binary messages? How are they used differently?
| @@ -0,0 +1,182 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Note for this entire file
Ideally in the future.. Keep code modular and only put color specific variations into their own file or just use an if ___ toggle in the main script.
Fine for this PR, but something to fix in the future. Making note here to remember.
* readme updates * Remove unused grayscale arduino folder
|
Overall modularity needs improved, but going to go ahead and merge. Will improve modularity in future refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method: