lib/gis: Fix out of scope memory access error in file_name function call #4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymdatta
force-pushed
the
lib_gis_localmem
branch
from
4c2489c to
a209173
Compare
|
Seems to me that moving the declaration |
When execution takes else path, pname, a pointer, is set to point to a local variable array which has limited scope. This same pointer is accessed outside of the block containing the local variable, essentially creating a scenario where we are accessing memory outside its score, which is undefined behavior. Move the variable array out of the loop, so that it has the same scope as pname. This was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <[email protected]>
ymdatta
force-pushed
the
lib_gis_localmem
branch
from
a209173 to
e37531b
Compare
|
Thanks for the suggestion @nilason. It's much cleaner and effective way to solve the issue. I didn't think of it at all! :) |
nilason
approved these changes
Nov 8, 2024
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Nov 11, 2024
…all (OSGeo#4650) lib/gis: Fix out of scope memory access error in file_name() When execution takes else path, pname, a pointer, is set to point to a local variable array which has limited scope. This same pointer is accessed outside of the block containing the local variable, essentially creating a scenario where we are accessing memory outside its score, which is undefined behavior. Move the variable array out of the loop, so that it has the same scope as pname. This was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When execution takes else path, pname, a pointer, is set to point to a local variable array which has limited scope. This same pointer is accessed outside of the block containing the local variable, essentially creating a scenario where we are accessing memory outside its score, which is undefined behavior.
Move the variable array out of the loop, so that it has the same scope as pname.
This was found using cppcheck static analysis tool.