Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fixed E721 in gunittest/ #4549

Merged
merged 2 commits into from
Oct 18, 2024
Merged

docs: Fixed E721 in gunittest/ #4549

merged 2 commits into from
Oct 18, 2024

Conversation

arohanajit
Copy link
Contributor

Fixed E721 by using isinstance() for type checks instead of ==
Also I went through some entries on .flake8 which were in the file but weren't detected on the running the flake8 check on there so I removed those as well

@github-actions github-actions bot added Python Related code is in Python libraries labels Oct 18, 2024
petrasovaa
petrasovaa requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to remove the invoker.py line from .flake8?

@arohanajit
Copy link
Contributor Author

Yes, I have updated the .flake8

@arohanajit arohanajit requested a review from petrasovaa October 18, 2024 18:57
@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 18, 2024
@petrasovaa petrasovaa merged commit 5cff700 into OSGeo:main Oct 18, 2024
26 checks passed
@a0x8o a0x8o mentioned this pull request Oct 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
libraries Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arohanajit @petrasovaa