Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: Fixed unused variable F841 #4542

Merged
merged 1 commit into from
Oct 17, 2024
Merged

wxGUI: Fixed unused variable F841 #4542

merged 1 commit into from
Oct 17, 2024

Conversation

arohanajit
Copy link
Contributor

Fixed F841: unused variable in wxgui.py by directly calling the constructor

petrasovaa
petrasovaa approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I am not sure how this one works, but this change is probably safe.

@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 17, 2024
@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Oct 17, 2024
@petrasovaa petrasovaa merged commit 0adc4dc into OSGeo:main Oct 17, 2024
26 checks passed
@arohanajit arohanajit deleted the 841-wxgui branch October 17, 2024 20:32
@a0x8o a0x8o mentioned this pull request Oct 18, 2024
Merged
@petrasovaa
Copy link
Contributor

@arohanajit I am taking that back, for some unknown (to me) reason, this breaks 3D view. So please revert this and put noqa there.

@echoix
Copy link
Member

echoix commented Oct 25, 2024

There should be a revert PR button in the github interface.

@petrasovaa
Copy link
Contributor

There should be a revert PR button in the github interface.

I meant just creating a new PR with the change and adding noqa there, not actually reverting it, but whatever works.

@arohanajit arohanajit mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arohanajit @petrasovaa @echoix