lib/db: remove deprecated implementation of db_set_login() and replace it with that of db_set_login2() #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a similar vein to OSGeo#4302, remove deprecated implementation of db_set_login() and replace it with that of db_set_login2(). Along with db_get_login(), db_set_login() was deprecated (in favour of db_set_login2) in 2015 with the 7.8.0 release. Commit: da399c5 Signed-off-by: Mohan Yelugoti <[email protected]>
github-actions
bot
added
C
ymdatta
changed the title
db_set_login() is deprecated in 7.8.0 release with da399c5. Change its function signature and implementation to match that of currently preferred db_set_login2(). Modify db_set_login2() to internally call db_set_login() function call. In the future major version, db_set_login() would be removed to have only one method to set login details for simplicity. Signed-off-by: Mohan Yelugoti <[email protected]>
ymdatta
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wenzeslaus
approved these changes
Sep 23, 2024
|
What's the plan on getting this PR and #4302 merged? Both are approved, and don't seem to have work to do anymore. Both have some failing checks, so I didn't act on them. |
|
I just noticed this one and #4302 earlier today and was wondering why we didn't merge it. I think when I reviewed it, I was thinking @nilason may want to have a look before merging or merge it since he initiated the change. However, I didn't actually express that anywhere. I'm happy to revisit if no one else will in the following days, so I'm assigning myself. |
nilason
approved these changes
Oct 23, 2024
wenzeslaus
pushed a commit
that referenced
this pull request
Oct 23, 2024
…e it with that of db_get_login2() (#4302) `db_get_login()` is deprecated in 7.8.0 release with da399c5. Change its function signature and implementation to match that of the currently preferred `db_get_login2()`. Technically, this is removing the old function and introducing a new one with the same name, but a different signature. Modify `db_get_login2()` to internally call `db_get_login()` function call. In the next major version, `db_get_login2()` should be removed to have only one method to get login details for simplicity. See also #4308. --------- Signed-off-by: Mohan Yelugoti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar vein to that of #4302,
db_set_login()is deprecated in 7.8.0 release with da399c5. Change its function signature and implementation to match that of currently preferreddb_set_login2().Modify
db_set_login2()to internally calldb_set_login()function call. In the future major version,db_set_login()would be removed to have only one method to set login details for simplicity.