Implement Bot Admin-only functionality #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someyuck
changed the title
ankith26
reviewed
Apr 14, 2024
bot/main.py
Outdated
|
|
||
| if server_config is None: | ||
| return False | ||
| if not is_bot_admin(str(user_id)): | ||
| raise CheckFailedException("is_academic_or_bot_admin") | ||
| return server_config.get("is_academic", False) |
There was a problem hiding this comment.
The is_bot_admin block will not run in this codepath (when server_config is not None), it would be needed here as well
ankith26
reviewed
Apr 14, 2024
bot/main.py
Outdated
| @@ -45,12 +53,22 @@ | |||
| MONGO_DATABASE = os.getenv("MONGO_DATABASE") | |||
| MONGO_URI = os.getenv("MONGO_URI") | |||
| BASE_URL = os.getenv("BASE_URL") | |||
| BOT_ADMINS = os.getenv("BOT_ADMINS").split(",") | |||
There was a problem hiding this comment.
Just a preference, I'd like to store this as a list of ints instead. So that checks are more convenient and we don't have to convert id to str everytime
ankith26
reviewed
Apr 15, 2024
| if ( | ||
| isinstance(error, commands.CheckFailure) | ||
| and isinstance(error.original, CheckFailedException) | ||
| and error.original.check_name == "is_author_bot_admin" |
There was a problem hiding this comment.
In my testing, this codepath isn't being triggered. So the thing is the .original attribute does not contain the original error raised.
ankith26
force-pushed
the
master
branch
2 times, most recently
from
8eb9229 to
dd96fe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves 4 tasks out of the 6 listed in the issue.
.envfile.backend_infoan admin command.I've also added docstrings for the functions defined, and updated the module docstring with those functions.