-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DependenciesProvider #88
Conversation
nice change. I think that the most important thing here is changing the prefix for the overriding client's cache. I'll talk to @EladBezalel and we'll try to challenge this solution to see that everything works fine. In the meantime can you please check the the example project works the same? I think you did not break any API but just to be sure. |
3bfcbbf
to
d16cb23
Compare
@eladav example project works the same |
6bdeb83
to
53aad8a
Compare
@eladav @EladBezalel what's up? any comments? requests? something? |
@nataly87s sorry for the delay...looking at both PRs now. |
So the reason we're having a hard time with this change is more conceptual than code-wise. The implementation looks 💯. If you worry about dependencies and bundle size it might still be easier to bundle the child component along with the host component as it already has the required dependencies. Am I missing something? wdyt? @EladBezalel feel free to chime in if you're available 🤔 |
@eladav I want to have an app with as few dependencies as possible, and a dynamic component that will inject all the other dependecies, so that if I want to update a package I won't have to publish a new version of the app, just a new version of the main component. |
@eladav @EladBezalel sup? |
53aad8a
to
27a9aa8
Compare
related to #87