Remove warnings 1 #255
Merged
Remove warnings 1 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced with lambdas
Conflicts: Array.cc HTTPCache.cc
There are some compiler warnings that come from code that is automatically generated and we cannot fix.
There are some compiler warnings that come from code that is automatically generated and we cannot fix.
|
Conflicts: Array.cc ce_expr.lex
…into remove-warnings-1
|
ndp-opendap
approved these changes
Nov 25, 2024
DDS.cc
Outdated
| @@ -1202,8 +1206,13 @@ void DDS::print_xml_writer(ostream &out, bool constrained, const string &blob) { | |||
| // Print the global attributes | |||
| d_attr.print_xml_writer(xml); | |||
|
|
|||
| // Print each variable | |||
| #if 0 | |||
There was a problem hiding this comment.
Is this going away?Should it stay? What do?
Grid.cc
Outdated
| @@ -713,6 +713,8 @@ void Grid::print_xml(ostream &out, string space, bool constrained) { | |||
| out << xml.get_doc(); | |||
| } | |||
|
|
|||
| #if 0 | |||
There was a problem hiding this comment.
Is this going away?Should it stay? What do?
Grid.cc
Outdated
| @@ -765,7 +779,18 @@ void Grid::print_xml_writer(XMLWriter &xml, bool constrained) { | |||
|
|
|||
| get_array()->print_xml_writer(xml, constrained); | |||
|
|
|||
| #if 0 | |||
There was a problem hiding this comment.
Is this going away?Should it stay? What do?
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| // The d4_function_parser.tab.cc and .hh files define and declare this class | |||
| %define parser_class_name {D4FunctionParser} | |||
| // %define api.parser.class {D4FunctionParser} | |||
| // %define api.parser.class {D4FunctionParser}. Waiting on RHEL8 to upgrade bison. jhrg 7/19/24 | |||
|
|
All suggestions followed. I'm going to merge now. I might look into the code smells as time allows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove warnings associated with the use of unary_function.
Some of these I replaced with lambda functions, some with range-based
for loops.