Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.05.04 final release fixes #2893

Open
wants to merge 31 commits into
base: develop/main374
Choose a base branch
from

Merge remote-tracking branch 'origin/develop/main374' into 1.05.04-fi…

d9ea078
Select commit
Loading
Failed to load commit list.
Open

1.05.04 final release fixes #2893

Merge remote-tracking branch 'origin/develop/main374' into 1.05.04-fi…
d9ea078
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 1s

54.78% (-0.02%) compared to 444b2c8, passed because coverage increased by 0.08% when compared to adjusted base (54.69%)

View this Pull Request on Codecov

54.78% (-0.02%) compared to 444b2c8, passed because coverage increased by 0.08% when compared to adjusted base (54.69%)

Details

Codecov Report

Attention: Patch coverage is 57.67717% with 215 lines in your changes missing coverage. Please review.

Project coverage is 54.78%. Comparing base (444b2c8) to head (d9ea078).

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 47.20% 140 Missing and 11 partials ⚠️
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 68.18% 41 Missing and 8 partials ⚠️
Stack/Opc.Ua.Core/Schema/UANodeSet.cs 50.00% 3 Missing ⚠️
Stack/Opc.Ua.Core/Types/BuiltIn/ExtensionObject.cs 0.00% 1 Missing and 1 partial ⚠️
Stack/Opc.Ua.Core/Types/Encoders/BinaryDecoder.cs 0.00% 2 Missing ⚠️
Stack/Opc.Ua.Core/Types/Encoders/BinaryEncoder.cs 0.00% 2 Missing ⚠️
Stack/Opc.Ua.Core/Types/Encoders/XmlDecoder.cs 0.00% 2 Missing ⚠️
Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs 0.00% 2 Missing ⚠️
...es/Opc.Ua.PubSub/Transport/MqttPubSubConnection.cs 88.88% 1 Missing ⚠️
Stack/Opc.Ua.Core/Stack/Client/UserIdentity.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           develop/main374    #2893      +/-   ##
===================================================
- Coverage            54.79%   54.78%   -0.02%     
===================================================
  Files                  349      349              
  Lines                66372    66657     +285     
  Branches             13622    13733     +111     
===================================================
+ Hits                 36371    36515     +144     
- Misses               26011    26146     +135     
- Partials              3990     3996       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.