-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ocrd v3 #216
Open
bertsky
wants to merge
35
commits into
OCR-D:master
Choose a base branch
from
bertsky:migrate-ocrd-v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate ocrd v3 #216
Changes from 4 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
4f98e6d
adapt to ocrd v3 Processor init (automatic ocrd-tool.json loading)
bertsky a9168e0
tests: adapt to ocrd v3 init (setup only via run_processor)
bertsky eb661f4
adapt to ocrd v3 (process→process_page_pcgts)…
bertsky 95d2837
require ocrd>=3.0
bertsky 47dee36
ocrd-tool.json: add cardinality specs
bertsky e9d562b
require ocrd 3.0 prerelease
bertsky f6c5ea0
binarize: use final v3 API
bertsky 3fd8265
crop: adapt to final v3 API
bertsky a66fbbe
deskew: adapt to final v3 API
bertsky ae10667
fontshape: adapt to final v3 API
bertsky 4c22245
recognize: use final v3 API
bertsky 491003f
segment: adapt to final v3 API
bertsky 0adfdee
segment_line: adapt to final v3 API
bertsky 1d7efa5
segment_region: adapt to final v3 API
bertsky aadd01b
segment_table: adapt to final v3 API
bertsky f5099c7
segment_word: adapt to final v3 API
bertsky 013de28
deskew: no segment.id for suffix on page level
bertsky ff258a3
CI: ex py37, in py311
bertsky 276735b
adapt to v3 b1, replace inheritance w/ proxy pattern
bertsky 7ae25a3
tests: adapt to etree in v3 b1
bertsky ef09995
require ocrd>=3.0.0b1
bertsky 972ac76
test_recognize: also test with METS Server and METS caching
bertsky a0d7ffa
limit max_workers=1 (libtesseract is not thread-safe)
bertsky a406400
conftest: simplify
bertsky 81fe66f
require ocrd>=3.0.0b3
bertsky 4e7fa70
test_cli: use subprocess CLI instead of monkeypatching env for TESSDA…
bertsky b76a4f5
test: all in pytest call
bertsky c9b8f3a
test: do not skip failured pages
bertsky 6d26cf0
require ocrd>=3.0.0b4
bertsky 6ca668e
require ocrd>=3.0.0b6 (mp), unlimit max_workers
bertsky 2a8b23b
test: simplify, use all configs in all tests
bertsky 8dc5a4f
Merge branch 'master' into migrate-ocrd-v3
bertsky 23d7f7f
CI: add RAM, more verbose
bertsky 1a157a5
require core >= 3
kba e0e5e4d
update tesser{act,ocr}
kba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides missing the typing, this has a different signature, pcgts is not variadic here. Python allows this and it is convenient but I am wondering whether it would be better to be consistent with the typing and signature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typing – sure, I was just to lazy again.
Variadic – I thought it would be clearer like that. So we would not have to do any arity checking in the function itself – a type checker could simply detect invalid use cases which do pass multiple pages at once. But perhaps I am wrong. (Also, we already have the arity assertion in
setup
.)