-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub action for macOS builds #423
Conversation
This pull request depends on pull request #410 and currently ignores errors from It must be triggered manually, but could also be run for example weekly in the future to detect any regressions earlier. |
I tried two different variants for getting the submodules:
So the. 2nd variant is much better, at least with |
Example result for this action: https://github.com/stweil/ocrd_all/actions/runs/8294000625/job/22698144574. |
.github/workflows/makeall-macos.yml
Outdated
if: runner.os == 'macOS' | ||
run: LC_ALL=C PKG_CONFIG_PATH=$HOMEBREW_PREFIX/opt/icu4c/lib/pkgconfig:$HOMEBREW_PREFIX/opt/libarchive/lib/pkgconfig make all GIT_DEPTH="--depth 1" | ||
- name: Make check | ||
run: make check || echo "make check failed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: make check || echo "make check failed" | |
run: make check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Note that the check will now fail until ocrd_froc was updated.
.github/workflows/makeall-macos.yml
Outdated
type: choice | ||
options: | ||
- 'default' | ||
- '3.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- '3.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thank you for your review.
Signed-off-by: Stefan Weil <[email protected]>
No description provided.