Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for macOS builds #423

Merged
merged 1 commit into from
May 25, 2024
Merged

Add GitHub action for macOS builds #423

merged 1 commit into from
May 25, 2024

Conversation

stweil
Copy link
Collaborator

@stweil stweil commented Mar 15, 2024

No description provided.

@stweil stweil marked this pull request as draft March 15, 2024 09:29
@stweil
Copy link
Collaborator Author

stweil commented Mar 15, 2024

This pull request depends on pull request #410 and currently ignores errors from make check because of issue OCR-D/ocrd_froc#10.

It must be triggered manually, but could also be run for example weekly in the future to detect any regressions earlier.

@stweil
Copy link
Collaborator Author

stweil commented Mar 15, 2024

I tried two different variants for getting the submodules:

  1. action/checkout can get all submodules recursively. By default it uses depth 1, but as it gets more submodules than required, it takes 189 s for the checkout step.
  2. Get submodules during the build process (make all GIT_DEPTH="--depth 1"). That costs about 45 s during the build step, but reduces the time for the checkout step to 1 s.

So the. 2nd variant is much better, at least with GIT_DEPTH="--depth 1" which should be used by all CI and Docker builds. Currently those builds don't use it.

@stweil
Copy link
Collaborator Author

stweil commented Mar 15, 2024

@stweil stweil marked this pull request as ready for review March 30, 2024 15:57
@stweil stweil requested a review from kba April 29, 2024 06:10
if: runner.os == 'macOS'
run: LC_ALL=C PKG_CONFIG_PATH=$HOMEBREW_PREFIX/opt/icu4c/lib/pkgconfig:$HOMEBREW_PREFIX/opt/libarchive/lib/pkgconfig make all GIT_DEPTH="--depth 1"
- name: Make check
run: make check || echo "make check failed"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: make check || echo "make check failed"
run: make check

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Note that the check will now fail until ocrd_froc was updated.

type: choice
options:
- 'default'
- '3.7'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '3.7'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for your review.

@bertsky bertsky merged commit fd516a4 into OCR-D:master May 25, 2024
1 check passed
@stweil stweil deleted the macos branch May 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants