Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub action for docker build #358

Closed
wants to merge 1 commit into from

Conversation

stweil
Copy link
Collaborator

@stweil stweil commented Mar 16, 2023

  • Remove the time consuming calculation of used disk space.
  • Remove all container images (more robust than removing single images).

- Remove the time consuming calculation of used disk space.
- Remove all container images (more robust than removing single images).

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Collaborator Author

stweil commented Mar 16, 2023

@kba, please include this PR also in the next release.

@stweil stweil mentioned this pull request Mar 16, 2023
@bertsky
Copy link
Collaborator

bertsky commented Jun 16, 2023

#362 had better solutions. (And you cannot remove all docker images, as you will need the currently relevant Ubuntu versions.)

@bertsky bertsky closed this Jun 16, 2023
@stweil
Copy link
Collaborator Author

stweil commented Jun 16, 2023

Removing all docker images would have been the simplest solution. And it works because the required Ubuntu image (and only that one) will simply be installed when required. That does not take much time.

@bertsky
Copy link
Collaborator

bertsky commented Jun 16, 2023

Removing all docker images would have been the simplest solution. And it works because

It does not work. I have tried that elsewhere. Also, as the names keep changing, opt-in is not predictable.

@stweil stweil deleted the fix-docker-action branch June 17, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants