Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] stock_available_to_promise_release: Make previous sql hookable #769

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Oct 21, 2023

In order to make the computation of the previous to promised sql hookable.
I move the need_release check into a own method.
This would makes it easier to add other moves to the where.

cc @jbaudoux

@mt-software-de mt-software-de force-pushed the 14-release-previous-domain branch from 100249b to 2e6a6ed Compare October 22, 2023 08:26
@mt-software-de
Copy link
Contributor Author

ping @jbaudoux or maybe @mmequignon ? :-)

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mt-software-de
Copy link
Contributor Author

Could you maybe review this?
@sebalix @simahawk
@jguenat @kluna1998

Copy link
Member

@jguenat jguenat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@jbaudoux
Copy link
Contributor

jbaudoux commented Nov 9, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-769-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a0149c7 into OCA:14.0 Nov 9, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 376f476. Thanks a lot for contributing to OCA. ❤️

@mt-software-de
Copy link
Contributor Author

Code review LGTM

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants