-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] stock_release_channel: Allow to see inactive partners #766
[16.0][FIX] stock_release_channel: Allow to see inactive partners #766
Conversation
Hi @sebalix, |
c20d891
to
e7d3828
Compare
This PR has the |
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
@sebalix your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-sebalix-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot rebase |
@sebalix The rebase process failed, because command
|
@rousseldenis can you rebase your PR please? |
e15e5cc
to
53c8489
Compare
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
On my way to merge this fine PR! |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
As the filter to assign channel will take into account void partner_ids field (allow all) or filled in (allow only those ones), the resulting query take into account inactive partners. Debug is difficult as form will show void partners even if the relation table contain records.
53c8489
to
5c80621
Compare
/ocabot merge patch |
On my way to merge this fine PR! |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 060c85a. Thanks a lot for contributing to OCA. ❤️ |
As the filter to assign channel will take into account void partner_ids field (allow all) or filled in (allow only those ones), the resulting query take into account inactive partners. Debug is difficult as form will show void partners even if relation table contain records.