Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_release_channel: Allow to see inactive partners #766

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

rousseldenis
Copy link
Contributor

As the filter to assign channel will take into account void partner_ids field (allow all) or filled in (allow only those ones), the resulting query take into account inactive partners. Debug is difficult as form will show void partners even if relation table contain records.

@OCA-git-bot
Copy link
Contributor

Hi @sebalix,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis added enhancement New feature or request needs review labels Oct 13, 2023
@rousseldenis rousseldenis added this to the 16.0 milestone Oct 13, 2023
@rousseldenis rousseldenis force-pushed the 16.0-fix-release-channel-partner-dro branch from c20d891 to e7d3828 Compare October 13, 2023 13:23
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebalix sebalix changed the title [FIX] stock_release_channel: Allow to see inactive partners [16.0][FIX] stock_release_channel: Allow to see inactive partners Oct 27, 2023
@sebalix
Copy link
Contributor

sebalix commented Oct 27, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-766-by-sebalix-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 27, 2023
Signed-off-by sebalix
@OCA-git-bot
Copy link
Contributor

@sebalix your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-sebalix-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sebalix
Copy link
Contributor

sebalix commented Oct 31, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@sebalix The rebase process failed, because command git push --force acsone tmp-pr-766:16.0-fix-release-channel-partner-dro failed with output:

remote: Permission to acsone/wms.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/acsone/wms/': The requested URL returned error: 403

@sebalix
Copy link
Contributor

sebalix commented Oct 31, 2023

@rousseldenis can you rebase your PR please?

@rousseldenis rousseldenis force-pushed the 16.0-fix-release-channel-partner-dro branch 2 times, most recently from e15e5cc to 53c8489 Compare November 11, 2023 15:28
@rousseldenis
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 11, 2023
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 11, 2023
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

As the filter to assign channel will take into account void partner_ids field (allow all)
or filled in (allow only those ones), the resulting query take into account inactive
partners. Debug is difficult as form will show void partners even if the relation table
contain records.
@rousseldenis rousseldenis force-pushed the 16.0-fix-release-channel-partner-dro branch from 53c8489 to 5c80621 Compare November 11, 2023 16:37
@rousseldenis
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 11, 2023
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-766-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 23a888b into OCA:16.0 Nov 12, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 060c85a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants