Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD] bookstore_mgmt: New module bookstore_mgmt #18

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[17.0][ADD] bookstore_mgmt: New module bookstore_mgmt #18

merged 1 commit into from
Nov 6, 2024

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Nov 5, 2024

This application manages books as products, authors, editorials and genres.

cc https://github.com/APSL 163007
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko please review

@peluko00 peluko00 mentioned this pull request Nov 5, 2024
Closed
@peluko00 peluko00 force-pushed the 17.0-add-bookstore_mgmt branch from 9ef3072 to efb3f36 Compare November 5, 2024 14:32
@peluko00 peluko00 force-pushed the 17.0-add-bookstore_mgmt branch from efb3f36 to bf2c0eb Compare November 5, 2024 14:35
BernatObrador
BernatObrador approved these changes Nov 5, 2024
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppyczko
ppyczko approved these changes Nov 6, 2024
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@peluko00
Copy link
Author

peluko00 commented Nov 6, 2024

Can you review it @pedrobaeza when you have a moment please.
Thanks!

mpascuall
mpascuall approved these changes Nov 6, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@pedrobaeza pedrobaeza added this to the 17.0 milestone Nov 6, 2024
@pedrobaeza
Copy link
Member

Well, I can't review all your PRs, also because I may not know about the features.

Being a new module, and I trust that your team has done an honest review, let's merge it.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-18-by-pedrobaeza-bump-nobump, awaiting test results.

@peluko00
Copy link
Author

peluko00 commented Nov 6, 2024 •
edited
Loading

Well, I can't review all your PRs, also because I may not know about the features.

Being a new module, and I trust that your team has done an honest review, let's merge it.

/ocabot merge nobump

Many thanks! It's possible to add me as PSC because i'm working in a new module for this repo?

@OCA-git-bot OCA-git-bot merged commit 21ca2cd into OCA:17.0 Nov 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8308067. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

Put you as maintainer of the module, and it requires less bureaucracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernatObrador BernatObrador BernatObrador approved these changes

@mpascuall mpascuall mpascuall approved these changes

@ppyczko ppyczko ppyczko approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@peluko00 @pedrobaeza @OCA-git-bot @BernatObrador @mpascuall @ppyczko