-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] connector_search_engine: missing typing-extensions external dependency #194
Conversation
86b2271
to
43d2526
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix
I don't know if the lib has to be added manually in requirement file, because it say it is "generated from manifests external_dependencies".
I am not sure though and I guess it won't hurt.
Pre-commit does the job for you if you add a dependency in manifest |
I didn't run pre-commit on my local branch, so I had to add the lib to the requirements manually as the pre-commit test went red here. Anyway, @OCA/search-engine-maintainers is it possible to merge this trivial PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florian-dacosta @clementmbr just to make it clear: usually you run pre-commit locally and it adds the dependencies in requirements.txt, and you should commit them along with the change to make the CI happy. But adding it manually like @clementmbr did is perfectly fine as long as you put it at the right place so the requirements.txt generated by the CI matches it perfectly which is the case here.
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at e3585ba. Thanks a lot for contributing to OCA. ❤️ |
Trivial PR to fix this kind of bug in CI:
https://github.com/OCA/sale-channel/actions/runs/8332403108/job/22801435634?pr=17#step:7:446
This bug doesn't occur on search-engine repo because the module
search_engine_serializer_pydantic
usepydantic
which depends on python packagetyping-extensions
. So typing-extensions is loaded anyway.But when a module on another repo like
sale_channel
needs to useconnector_search_engine
without usingsearch_engine_serializer_pydantic
, the bug occurs.Once this PR is merged I will be able to merge OCA/sale-channel#17
cc @florian-dacosta @bealdav @rousseldenis @adrienpeiffer