Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] search_engine_image_thumbnail: Avoid error on view load #170

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Nov 22, 2023

In the thumbnail size form a domain is computed to restrict the model's field for which the size is defined. The build process filters of type FSImage of relational field to image relation model. In this mechanism we check the comodel_name info to validate the related model if a comodel_name is defined on a field. In some cases (related), the comodel_name doesn't refer to an odoo model. (A bug?). We now ignore fields with a comodel_name not part of the registry

In the thumbnail size form a domain is computed to restrict the model's field for which the size is defined. The build process filters of type FSImage of relational field to image relation model. In this mechanism we check the comodel_name info to validate the related model if a comodel_name is defined on a field. In some cases (related), the comodel_name doesn't refer to an odoo model. (A bug?). We now ignore fields with a comodel_name not part of the registry
@lmignon
Copy link
Contributor Author

lmignon commented Nov 22, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-170-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 96db805 into OCA:16.0 Nov 22, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 182df19. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-fix-thumbnail-size-selection branch November 22, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants