-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 18.0 #733
base: 18.0
Are you sure you want to change the base?
Conversation
[UPD] Update queue_job_batch.pot
* incorrect sintax in security rule * change missleading name of security rule
standard migration and some little ux improvements: now hide button is a fa-check button that on click just marks as read the batch, do not navigate to it and updates immediately the systray. [UPD] Update queue_job_batch.pot
[UPD] Update queue_job_batch.pot
[UPD] Update test_queue_job_batch.pot
[UPD] Update test_queue_job_batch.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-16.0/queue-16.0-test_queue_job_batch Translate-URL: https://translation.odoo-community.org/projects/queue-16-0/queue-16-0-test_queue_job_batch/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
"company_id": company_id, | ||
} | ||
) | ||
return self.sudo().create(vals).with_user(self.env.uid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this syntax can be better:
return self.sudo().create(vals).with_user(self.env.uid) | |
return self.sudo().create(vals).sudo(False) |
company_id = self.env.user.company_id.id | ||
|
||
if "company_id" in self.env.context: | ||
company_id = self.env.context["company_id"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also be:
company_id = self.env.user.company_id.id | |
if "company_id" in self.env.context: | |
company_id = self.env.context["company_id"] | |
company_id = self.env.context.get("company_id", self.env.user.company_id.id) |
HELP IS NEEDED
I’ve started the migration and JS code analysis.
The “messaging” JS code was heavily refactored starting v17 with this commit:
I’m not familiar with the module and don’t know how it’s expected to work.
I’ve checked the JS changes and write some pseudo code:
https://github.com/OCA/queue/pull/733/files#diff-bc23bdd925614b2acfed835f19bb33416f7a6f4ee37a15938971d2c309aa2a0e
ping @ivantodorovich