Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] *_operating_unit: add check_company in field OU #736

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

Saran440
Copy link
Member

Step to test:

  1. Add multi company and create OU
    Selection_019

  2. Go to invoice, po, so, exp or else > select Operating Unit field it will show all OU
    Selection_020

This document created on YourCompany it should select OU that depend on YourCompany only
This PR fixed by add check_company=True in header field.

Exclude: line, compute field, wizard (may be it should add too. but I didn't test)

After add it
Selection_021

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @ps-tubtim,
some modules you are maintaining are being modified, check this out!

@AaronHForgeFlow
Copy link
Contributor

Too bad. It seems OU modules are not multicompany consistent :S

The changes are good to me, and I think we should merge this. Multicompany production instances may need to check their data before applying this change. I will wait for other contributors to give their opinion first.

I think having a commit per module is required in OCA, sorry for the pain.

@Saran440
Copy link
Member Author

@AaronHForgeFlow No problem. I think it’s the right thing to do.
However, should we start fixing this from version 18?

Because so far, no one has multi ou in multi company.

@AaronHForgeFlow
Copy link
Contributor

I don't use this in a multicompany environment and I won't be affected. In any case I think it is best to fix the bug in any version.

@AaronHForgeFlow
Copy link
Contributor

I checked and it seems to be already solved in v17. I did not test v16.

It is ok to merge it and check if needed in v16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants