Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] mgmtsystem_quality: Update CONTRIBUTORS.rst #556

Merged
merged 2 commits into from
Dec 9, 2023
Merged

[IMP] mgmtsystem_quality: Update CONTRIBUTORS.rst #556

merged 2 commits into from
Dec 9, 2023

Conversation

max3903
Copy link
Member

@max3903 max3903 commented Nov 22, 2023

No description provided.

@max3903 max3903 added this to the 16.0 milestone Nov 22, 2023
@max3903 max3903 self-assigned this Nov 22, 2023
@dreispt
Copy link
Member

dreispt commented Nov 27, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2023
@OCA-git-bot
Merge PR #556 into 16.0
824e2d1 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

dreispt commented Nov 27, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2023
@OCA-git-bot
Merge PR #556 into 16.0
d9967f0 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yassine-rhimi
Copy link
Contributor

Dear OCA Community Members,

I trust this message finds you well. I am writing to bring your attention to a matter that requires immediate intervention. Currently, there are two pending commits awaiting merger and has not been deployed on pypi.org since October .

Your swift cooperation in merging these commits and updating the module is crucial to ensuring that the latest changes are reflected. This will allow the community to benefit from the improvements that have been made.

Below are the details of the pending commits:

Management System Module:

Translation Commit Date: November 20, 2023
Last Version Update: October 11, 2023
Pypi Link: https://pypi.org/project/odoo-addon-mgmtsystem/16.0.1.0.0.8/
Translation Fr Link: https://github.com/OCA/management-system/tree/16.0/mgmtsystem/i18n

Product Pricelist Revision Module:

Translation Commit Date: November 15, 2023
Last Update: October 30, 2023
Pypi Link: https://pypi.org/project/odoo-addon-product-pricelist-revision/
Translation Fr Link: https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_revision/i18n)
I kindly request your prompt attention to these matters and appreciate your cooperation in ensuring the timely deployment of the latest updates for the benefit of the entire community.

Thank you in advance for your support.

Best regards,

[Rhimi Yassine]

@dreispt
Copy link
Member

dreispt commented Dec 4, 2023

@sbidoul Hi, there is a concern here that commits with translations coming from Weblate don't trigger PyPi releases.
Indeed, waiting for the next fix to be pushed to have the translations released is not a reliable process.
Any idea on how to handle this?

@dreispt
Copy link
Member

dreispt commented Dec 4, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 4, 2023
@OCA-git-bot
Merge PR #556 into 16.0
eb2ddba 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul
Copy link
Member

sbidoul commented Dec 4, 2023

Hi, there is a concern here that commits with translations coming from Weblate don't trigger PyPi releases. Indeed, waiting for the next fix to be pushed to have the translations released is not a reliable process. Any idea on how to handle this?

@dreispt the bot is doing a nightly release with all the main branches. So this is new and I'm noting to investigate this as soon as I can.

@sbidoul
Copy link
Member

sbidoul commented Dec 4, 2023

Also, I don't immediately see why your merge command failed. That is weird.

@dreispt
Copy link
Member

dreispt commented Dec 4, 2023

Thank you @sbidoul .
Indeed, the bot's build is green. Trying again just in case.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 4, 2023
@OCA-git-bot
Merge PR #556 into 16.0
3872370 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul
Copy link
Member

sbidoul commented Dec 4, 2023

This may explain things
image

flotho
flotho approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I sadly approve this PR
@max3903 is leaving us ;-)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Dec 9, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 9, 2023
@OCA-git-bot
Merge PR #556 into 16.0
d451683 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

dreispt commented Dec 9, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-556-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 51ec42b into OCA:16.0 Dec 9, 2023
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d1aa7d0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotho flotho flotho approved these changes

@dreispt dreispt dreispt approved these changes

Assignees

@max3903 max3903

Labels
approved enhancement merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@max3903 @dreispt @OCA-git-bot @yassine-rhimi @sbidoul @flotho