Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] l10n_fr_account_vat_return: fix journal entry generated in negative VAT scenario + many improvements #563

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

alexis-via
Copy link
Contributor

Add test to check the journal entry in negative scenario and improve tests on the generated journal entry in all scenarios

Full re-implementation of the product/service distribution for autoliquidation VAT accounts: we now support autoliquidation VAT accounts in all journals (error if found in sale journal) and not just purchase journal. When auto computation of product/service distribution is not possible, we trigger a wizard to ask the user.

Add message in chatter if ignoring draft moves.

This is a forward port of https://github.com/OCA/l10n-france/pull/562/files

… VAT scenario

Add test to check the journal entry in negative scenario and
improve tests on the generated journal entry in all scenarios

Full re-implementation of the product/service distribution for
autoliquidation VAT accounts: we now support autoliquidation VAT
accounts in all journals (error if found in sale journal) and not just
purchase journal. When auto computation of product/service distribution
is not possible, we trigger a wizard to ask the user.

Add message in chatter if ignoring draft moves.
Copy link

@LaetitiaElabore LaetitiaElabore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and approved

Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested and use in production

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alexis-via
Copy link
Contributor Author

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-563-by-alexis-via-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4a364d3 into OCA:16.0 Nov 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f22b0a7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants