Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] MIS Reports templates for Balance Sheet and Profit & Loss #205

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

mathisjacoby
Copy link
Contributor

@mathisjacoby mathisjacoby commented Sep 22, 2023

New reports in l10n_be_mis_reports for the micro, abridged and full model templates for the Balance Sheet and the Profit & Loss for :

  • Companies with capital
  • Companies without capital
  • Non-profit institution

The templates are generated with two scripts located in the 'script' folder, which use JSON files containing data from the Central Balance Sheet Office taxonomy.

They are available in English, French, Dutch and German.

The KPI names are structured for an other module that will come later. This module will allow to generate XBRL instances, ready to be submitted to the National Bank of Belgium.

@mathisjacoby mathisjacoby force-pushed the 16.0-add_l10n_be_mis_reports_templates branch 2 times, most recently from 54ce510 to 468f504 Compare September 25, 2023 09:06
@sbidoul sbidoul force-pushed the 16.0-add_l10n_be_mis_reports_templates branch from 468f504 to b046a71 Compare December 31, 2023 10:32
@sbidoul
Copy link
Member

sbidoul commented Jan 1, 2024

I tested this on real data for companies with capital (abridged model).

I think this is good to go. Thanks @mathisjacoby!

@mathisjacoby could you just prefix the report template titles with Belgium and add translations for these titles?

@mathisjacoby mathisjacoby force-pushed the 16.0-add_l10n_be_mis_reports_templates branch from b046a71 to 341015d Compare January 22, 2024 15:59
Add two scripts that generates the MIS Reports Templates for companies with and w/o capital, and associations (full, abridged and micro model)

json
@mathisjacoby mathisjacoby force-pushed the 16.0-add_l10n_be_mis_reports_templates branch from 341015d to e35894d Compare January 22, 2024 16:38
@mathisjacoby
Copy link
Contributor Author

@sbidoul Thanks for the review !

It's done. May you check if it's correct now ?

@vdewulf
Copy link
Contributor

vdewulf commented Feb 29, 2024

Hello,
Thanks for this work!
I compared the report for the balance sheet (full model) for the association with the model we created in our accounting company on version 12 community (manually) with the French language. I exported the reports in excel from both database. See attachment for full details.

I saw 2 differences

  • in v16 report, 2 lines are missing (Actions propres [50] et Autres placements [51/53]), but the total line 50/53 is there. This is thus not an issue and we might have added it in v12 even though it was not necessary (as we can see in the PDF of the official declaration).

  • the line "FONDS SOCIAL [10/15]" in our custom report is called in v16 "CAPITAUX PROPRES [10/15]", which is strange for an association who has no "capital". This is more of a (small) issue. The official PDF report available on the BNB website (https://www.nbb.be/doc/ba/models/npi/release%202023/release2021_fr_modele_complet_asbl_v8.pdf) indicates "Fonds social" as well.

I then created the report on the runboat database, and I see that active is different from passive section. This is, I suppose, linked to strange demo data on the accounting modules on runboat. I didn't investigate this.
v16_OCA-module_bilan_association_full-model_comp_bilan_v12_Chaf.xlsx

Conclusion: I'm wondering if the translation is really up to date, but except that, I think we can proceed with the merge of this PR (translations are easy to fix afterwards with Weblate or in production database directly if needed).

@sbidoul
Copy link
Member

sbidoul commented Feb 29, 2024

Thanks for the test @vdewulf.

I suspect the translation issue may reveal something in the way transalations are generated. @mathisjacoby could you have a quick look?

@mathisjacoby
Copy link
Contributor Author

Hi,

Thanks a lot for your review @vdewulf !

@sbidoul Of course, I'll have a look.

@sbidoul
Copy link
Member

sbidoul commented Mar 13, 2024

@mathisjacoby have you had a chance to look into the translation issue?

@mathisjacoby
Copy link
Contributor Author

@sbidoul Not yet, sorry. I just need to finish something else before.

Could it be next week or do you want me to check it now ?

@sbidoul
Copy link
Member

sbidoul commented Mar 26, 2024

@vdewulf the translation of Equity is a very special case.

First we have a limitation in Odoo where the export of the .pot file merges all terms of a module data files that have the same source language in English. So even if we split it manually to allow for a different translation of Equity for some reports, the CI will merge it again.

Second it seems that the translation of Equity for companies without capital (to Fonds Social) is only different in French (for Dutch and German we have the same translation as in other reports).

So there are two solutions: either we tweak the English term to be slightly different, or we just don't worry about it.

I'm going to merge as is, and we can address that in a followup.

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-205-by-sbidoul-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e8a4d37 into OCA:16.0 Mar 26, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2b08228. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-add_l10n_be_mis_reports_templates branch March 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants