Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_be_mis_reports_xml #198

Merged
merged 18 commits into from
Jan 11, 2024
Merged

[16.0][MIG] l10n_be_mis_reports_xml #198

merged 18 commits into from
Jan 11, 2024

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Jul 4, 2023 •
edited
Loading

@victor-champonnois victor-champonnois changed the title 16.0 mig l10n be mis reports xml [16.0][MIG] l10n_be_mis_reports_xml Jul 4, 2023
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_mis_reports_xml branch from 8060a0b to 746c314 Compare July 20, 2023 13:18
@victor-champonnois victor-champonnois marked this pull request as ready for review July 20, 2023 14:32
@victor-champonnois victor-champonnois force-pushed the 16.0-mig-l10n_be_mis_reports_xml branch 2 times, most recently from d06dc88 to deb141f Compare July 20, 2023 14:37
carmenbianca
carmenbianca approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awaiting functional testing

len-foss
len-foss approved these changes Oct 12, 2023
View reviewed changes
Copy link

@len-foss len-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: I used the XML file on Intervat for this trimester and it's correct.

@robinkeunen
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@robinkeunen The rebase process failed, because command git push --force coopiteasy tmp-pr-198:16.0-mig-l10n_be_mis_reports_xml failed with output:

remote: Permission to coopiteasy/l10n-belgium.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/l10n-belgium/': The requested URL returned error: 403

robinkeunen and others added 18 commits January 11, 2024 17:28
@robinkeunen
[ADD] l10n_be_mis_reports_xml: new module
8f7d875
@remytms @robinkeunen
[FIX] mis_reports_xml: be_vat_declaration add missing namespace
203b9a6
@remytms @robinkeunen
[FIX] mis_report_xml: declarant phone and declarant tax id
0d76653 
Phone and Tax ID should only contains numbers.
@oca-travis @robinkeunen
[UPD] Update l10n_be_mis_reports_xml.pot
a2dd645
@OCA-git-bot @robinkeunen
[UPD] README.rst
f300b03
@OCA-git-bot @robinkeunen
[ADD] icon.png
c8d6aea
@sbidoul @robinkeunen
Apply pre-commit
693c9a1
@OCA-git-bot @robinkeunen
l10n_be_mis_reports_xml 12.0.1.0.1
4aa06d4
@huguesdk @robinkeunen
[IMP] l10n_be_mis_reports_xml: black, isort, prettier
bbddf12
@huguesdk @robinkeunen
[FIX] coop it easy scrlfs → sc
5bed82f
@huguesdk @robinkeunen
[MIG] l10n_be_mis_reports_xml: migration to 13.0
172b7ac
@huguesdk @robinkeunen
[MIG] l10n_be_mis_reports_xml: migration to 14.0
bd29f2d
@huguesdk @robinkeunen
[IMP] avoid errors when some fields are not set
b7ce7f6 
avoid errors when some company fields are not set:
* display a user error if the vat field is not set (as it is mandatory)
* correctly handle the optional phone number field
@huguesdk @robinkeunen
[IMP] improve readme
7d2d694
@victor-champonnois @robinkeunen
[MIG] l10n_be_mis_reports_xml: Migration to 15.0
d01cb69
@victor-champonnois @robinkeunen
[MIG] l10n_be_mis_reports_xml: Migration to 16.0
23524aa
@victor-champonnois @robinkeunen
[IMP] : pre-commit stuff
f2b0813
@victor-champonnois @robinkeunen
[FIX] test (use belgian demo company)
9388072
@robinkeunen robinkeunen force-pushed the 16.0-mig-l10n_be_mis_reports_xml branch from deb141f to 9388072 Compare January 11, 2024 16:28
@robinkeunen
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-198-by-robinkeunen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c424353 into OCA:16.0 Jan 11, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0bcdae1. Thanks a lot for contributing to OCA. ❤️

@regispirard
Copy link

Nice ! Thank you @robinkeunen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmenbianca carmenbianca carmenbianca approved these changes

@len-foss len-foss len-foss approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@victor-champonnois @robinkeunen @OCA-git-bot @regispirard @carmenbianca @len-foss @remytms @oca-travis @sbidoul @huguesdk