-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] base_wamas_ubl PromiseDeliveryPeriod #1034
[16.0][IMP] base_wamas_ubl PromiseDeliveryPeriod #1034
Conversation
37aa086
to
9a311d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
68df30d
to
d309892
Compare
<cbc:EndDate>2023-05-01</cbc:EndDate> | ||
<cbc:EndTime>14:00:00</cbc:EndTime> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better if you use a different date & time in the test in Promise & Estimated otherwise you don't test the right one is going in the right place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adapted the test with distinct Promise & Estimated dates
d309892
to
90297de
Compare
/ocabot merge minor |
Sorry @jbaudoux you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@simahawk This one can be merged :) |
90297de
to
8a0bbd0
Compare
/ocabot merge minor |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 7948884. Thanks a lot for contributing to OCA. ❤️ |
No description provided.