Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] base_wamas_ubl PromiseDeliveryPeriod #1034

Merged

Conversation

santostelmo
Copy link
Contributor

No description provided.

@santostelmo santostelmo changed the title [IMP] base_wamas_ubl PromiseDeliveryPeriod [16.0][IMP] base_wamas_ubl PromiseDeliveryPeriod Sep 2, 2024
@santostelmo santostelmo force-pushed the 16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod branch 2 times, most recently from 37aa086 to 9a311d7 Compare September 5, 2024 09:40
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santostelmo santostelmo force-pushed the 16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod branch 2 times, most recently from 68df30d to d309892 Compare September 10, 2024 11:48
Comment on lines 68 to 69
<cbc:EndDate>2023-05-01</cbc:EndDate>
<cbc:EndTime>14:00:00</cbc:EndTime>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better if you use a different date & time in the test in Promise & Estimated otherwise you don't test the right one is going in the right place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adapted the test with distinct Promise & Estimated dates

@santostelmo santostelmo force-pushed the 16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod branch from d309892 to 90297de Compare September 12, 2024 07:53
@jbaudoux
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Sorry @jbaudoux you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@jbaudoux
Copy link
Contributor

@simahawk This one can be merged :)

@jbaudoux jbaudoux force-pushed the 16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod branch from 90297de to 8a0bbd0 Compare January 8, 2025 12:18
@jbaudoux
Copy link
Contributor

jbaudoux commented Jan 8, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1034-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8984647 into OCA:16.0 Jan 8, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7948884. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants