Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_delivery_carrier_label: Migration to 18.0 #935

Draft
wants to merge 114 commits into
base: 18.0
Choose a base branch
from

Conversation

imlopes
Copy link

@imlopes imlopes commented Jan 20, 2025

Depends on: #936

yvaucher and others added 30 commits January 16, 2025 16:41
… nesting, few typos

[ADD] access rights for the shipping.label model
[IMP] remove unused pdf_list variable and rename pdf variable to label as a label can have other printing format

[IMP] remove readonly on carrier_tracking_ref

[IMP] remove carrier_tracking_ref redefinition as already defined in delivery/stock.py

[ADD] stock users rights

[ADD] file type on shipping label

[ADD] pot file

[ADD] fr.po
…per pack (stock.tracking)

[IMP] set tracking_id as an optional key of dict returned by label generation and improve doc string

[IMP] rename generate_pack_labels in generate_shipping_labels as it can also generate a single label for a picking without pack notion

[IMP] set labels on stock.picking instead of stock.picking.out in order to let the creation of return labels to provide to the customer

[FIX] xml view and copy what is needed on stock.picking.out and stock.picking.in as it won't be inherited from stock.picking.out
[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option
…by raising a orm.except_orm

[FIX] trigger carrier_id on change when creating a stock.picking to set default options from sale.order

[IMP] change error message of unimplemented default to a more user friendly message
…te the label only for a selection of packs in a picking

the button call action_generate_carrier_label() without the 'context' keyword argument so the context ends in the tracking_ids argument. So the method now conforms to the cr, uid, ids, context signature and just forwards to a new generate_labels() method that should be used from within the code

do not overwrite the option_ids on create of stock.picking if already set in values, generalize the method to all types of picking (added in/out)

Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)
[FIX] action name

[IMP] add descrption field to carrier option
[IMP] file_type field inheritance in shipping.label

[IMP] add field selection sort
[FIX] docstring

[FIX] _customize_sender_address return method

[IMP] add comment in _customize_sender_adress()

[FIX] method name to get sender address

[FIX] method comment
move modules in __unported__
[REF] port to v8 with old api

[MIG] to v8 base_deliv_label, deliv_carrier_deposit

[IMP] add parcel_tracking field

[IMP] add _get_packages_from_picking()

add carrier_id in tree view
Better layout of default report for deposit slip
For stock.quant.package, order by id desc to have the latest first
Code cleanup

Button "Create Shipping Label" should be used when the picking in Done, because in v8 the packaging is handled in the "Transfer" wizard (in v7, the packaging could be made when the picking is waiting/ready)
Display number of packages on deposit slip
Add weight in tree view of packages
Remove an unused file 'reports.xml'

Remove the selection wrappers

Use the name of the method as string instead
Move module description in README.rst
Take the destination package. If empty, the package is moved so take the source
one.

The options must be filtered by the selected carrier
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
OCA-git-bot and others added 24 commits January 16, 2025 16:41
…er_label and migrate base_delivery_carrier_label to 16
…received in the data from the label generation
Better use of logging so tools like sentry deduplicate the message.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-17.0/delivery-carrier-17.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-17-0/delivery-carrier-17-0-base_delivery_carrier_label/
Currently translated at 100.0% (83 of 83 strings)

Translation: delivery-carrier-17.0/delivery-carrier-17.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-17-0/delivery-carrier-17-0-base_delivery_carrier_label/it/
Currently translated at 100.0% (83 of 83 strings)

Translation: delivery-carrier-17.0/delivery-carrier-17.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-17-0/delivery-carrier-17-0-base_delivery_carrier_label/it/
The migration to 17 of the test helper carrier_label_case was missing
the classmethod decorator on the setUpClass method
Previous fix was incomplete: the class method should only call other
class methods
Currently translated at 100.0% (83 of 83 strings)

Translation: delivery-carrier-17.0/delivery-carrier-17.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-17-0/delivery-carrier-17-0-base_delivery_carrier_label/it/
@imlopes imlopes force-pushed the 18.0-mig-base_delivery_carrier_label branch from aedb660 to 27de450 Compare January 20, 2025 15:44
@florian-dacosta
Copy link
Contributor

Hello @imlopes

Please check #896
And #900

We mainly still have to extract the shipping.label functionalities in v18. I plan to work on this soon.

@imlopes imlopes force-pushed the 18.0-mig-base_delivery_carrier_label branch from 20a96df to 9583155 Compare January 20, 2025 16:21
@florian-dacosta
Copy link
Contributor

And here is the other about the shipping.label model : #938

If these 2 modules are not enough to replace your usage of base_delivery_carrier_label, please tell me what more you are using and the context/usecase so we can think forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.