[17.0][MIG] delivery_free_fee_removal: Migration to 17.0 #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not, other tests can fail.
* Standard procedure Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_free_fee_removal/
[UPD] Update delivery_free_fee_removal.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_free_fee_removal/
Description of the issue on OCA#306. In short: the delivery sale line is required in 13.0 to be able: * see which delivery method is used * change the delivery method or update its price * remove the delivery method Removing entirely the line when the fee is free is therefore an issue. The free delivery line is kept, although greyed, in the sale order. However, it is considered as non-invoiceable, so it doesn't create an invoice line, and it is hidden from the sale report. Closes OCA#306 [UPD] Update delivery_free_fee_removal.pot [UPD] README.rst delivery_free_fee_removal 13.0.1.0.1 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_free_fee_removal/
The free delivery line stop the order from being fully invoiced. To fix that they are set as invoiced on order confirmation. [UPD] Update delivery_free_fee_removal.pot [UPD] README.rst delivery_free_fee_removal 13.0.1.0.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_free_fee_removal/
[UPD] Update delivery_free_fee_removal.pot [UPD] README.rst
juancarlosonate-tecnativa
force-pushed
the
17.0-mig-delivery_free_fee_removal
branch
from
8a5dd0a to
f4995c0
Compare
|
The sale_order_warehouse_from_delivery_carrier tests are failing. Can you check where the error is coming from, maybe there is a conflict with this module? |
|
/ocabot migration delivery_free_fee_removal |
Currently translated at 100.0% (3 of 3 strings) Translation: delivery-carrier-15.0/delivery-carrier-15.0-delivery_free_fee_removal Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-15-0/delivery-carrier-15-0-delivery_free_fee_removal/es/
pedrobaeza
force-pushed
the
17.0-mig-delivery_free_fee_removal
branch
2 times, most recently
from
1b951ea to
5429d67
Compare
juancarlosonate-tecnativa
force-pushed
the
17.0-mig-delivery_free_fee_removal
branch
from
5429d67 to
22652b9
Compare
|
ping @pedrobaeza |
pedrobaeza
reviewed
Jan 16, 2025
| ) | ||
| res = super()._compute_invoice_status() | ||
| for line in free_delivery_lines: | ||
| line.invoice_status = "invoiced" |
There was a problem hiding this comment.
Isn't better to be "Nothing to invoice"?
There was a problem hiding this comment.
then, the invoice status of the order will never change to "Fully Invoiced," as mentioned in ef35c48
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 26e7b36. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
TT52318 @Tecnativa
@pilarvargas-tecnativa @pedrobaeza can you check? thanks!