[16.0][MIG] contract_price_revision: Migration to 16.0 #1038
Conversation
houzefa-abba
force-pushed
the
16.0-mig-contract_price_revision
branch
2 times, most recently
from
dfd53cd to
d4768e6
Compare
|
Hi @carlosdauden @carolinafernandez-tecnativa this PR is ready, please review |
|
Functional Review LGTM :) Could you please squash administrative commits? Thanks!! |
Thanks for the review! :) I already squashed some bot & translation commits, which ones do you have in mind? Maybe the 13.0 ones? I'm hesitant in squashing those as they add features |
|
I attached the ones I was telling you before
|
houzefa-abba
force-pushed
the
16.0-mig-contract_price_revision
branch
from
d4768e6 to
a63ae59
Compare
|
Done! Looks better indeed |
|
Other thing you need to take into account according to this document https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0 you need to separate pre-commit init from migration Also commits about Translations you need to squash them. |
Hi pre-commit did not change anything in this case so there was nothing to commit pre-migration - my 16.0 migration commit does not contain any code formatting changes, unless you spot a specific one? I already squashed translation commits, could you show me which ones remain to be squashed please? |
|
/ocabot migration contract_price_revision |
houzefa-abba
force-pushed
the
16.0-mig-contract_price_revision
branch
from
a63ae59 to
6083a96
Compare
|
Rebased on latest 16.0 |
… anymore cherry-pick db5c3d6
…computed On new line creation when applying wizard, the stored values are not recomputed, so recomputing them
…ed field 'price_can_be_revised'
…se module Values for new line should come from _prepare_value_for_plan_successor function adding the new price.
…ome lines As if recurrence management is per line, some lines should be excluded from price revision.
Currently translated at 82.6% (19 of 23 strings) Translation: contract-15.0/contract-15.0-contract_price_revision Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract_price_revision/es/
Fix views in the process; variation % was not showing inside line list embedded into contract forms.
houzefa-abba
force-pushed
the
16.0-mig-contract_price_revision
branch
from
6083a96 to
5f4fb7d
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Fix views in the process; variation % was not showing inside line list embedded into contract forms.
Test case on runboat
Contract starts in 2024, invoiced every year, first invoice got produced, price = $500:
Run wizard with 10% increase in 2025:
The wizard stops my initial contract line and adds a new one in 2025 with price = $550:
