[16.0][IMP] account_reconcile_oca: Improve _compute_reconcile_data_info. When changing account_id on journal item, data displayed in reconcilitation menu now is updated

[sergiobstoj]

Current behaviour:

When changing account_id on move line, the account displayed in reconciliation menu is not getting updated.

before-pr.mp4

Behaviour with this PR:

account_id displayed in reconciliation menu is updated.

after-pr.mp4

[OCA-git-bot]

Hi @etobella,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

In fact, I see that account change as something incorrect, as you are changing the liquidity account.

[sergiobstoj]

I improved new method _check_recompute_reconcile_data to make it more generic and handle some other fields that could be changed.

About the account, I understand @pedrobaeza that you say it should not allow the account change? We are having some cases where it was necessary to change it due to mistake on counterpart account.

[pedrobaeza]

If you change the bank account, it's because you have added the transaction in the wrong journal, and just changing the bank account is not enough. You have to remove the transaction in that bank, and create it in the correct bank.

I still state that this base of this PR is not correct.