[16.0][IMP] account_financial_report: Set grouped_by as required with non grouped item description. Fixes display of report when no agroupation is wanted #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rouped item description. Fixes display of report when no agroupation is wanted
aritzolea
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two items.
In first place, the Grouped By field has two options that returns same result:
And with any of the two options, the result is not correct, as is not displaying all the data available for the accounts.
before-pr-general-ledger-group-by.mp4
With this PR we have the option limited to correct options:
And the result is displayed with all the info:
after-pr-general-ledger-group-by.mp4