Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use branch-local package-lock.json #4318

Merged

Conversation

ralfhandl
Copy link
Contributor

This change allows trusting the checks on dependabot PRs as they will now run with the updated dependencies.

@ralfhandl ralfhandl requested review from a team as code owners January 22, 2025 08:41
@handrews
Copy link
Member

@ralfhandl I assume this means we have to keep the JS environment in sync across branches. Or at least as in-sync as makes sense. Are you adding this because we want some to be different?

Can you update CONTRIBUTING.md with whatever the new policy is for making this work?

@ralfhandl
Copy link
Contributor Author

ralfhandl commented Jan 23, 2025

With the current state - running tests and validation with the package-lock.json from main - breaking changes in the validation and test tools and their dependencies will not be caught by the automated checks on a PR branch, which especially means that green checks on dependabot PRs have no meaning.

This PR improves that situation - green checks now mean that updating the dependencies will not break the validation and test tools.

I couldn't find documentation on why these workflows currently fetch package-lock.json from main.

@lornajane
Copy link
Contributor

Perhaps there should be some documentation covering the workflow of updating the other branches with dependencies. I think that's separate to this change, though, so it would be okay to capture what is needed as an issue.

Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it makes more sense to use the files in the current branch context.

@lornajane lornajane merged commit 245a4e2 into OAI:main Jan 23, 2025
2 checks passed
@ralfhandl ralfhandl deleted the workflows-use-branch-local-package.json branch January 23, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants