Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Type to distinguish gitlab DiffNote and DiscussionNote #19

Merged

Conversation

jonathanlam
Copy link
Member

Description

this field is in the DiffNote and DiscussionNote webhooks and allows us to distinguish a comment left on a code review vs a comment on the main Pull request

Checklist

  • I have added one of the patch, minor, major or no-release labels
  • I have linked an issue from this repository using the Development option
  • I have performed a self-review of my own code
  • I have checked for redundant or commented out code
  • I have commented my code where I can't make it self-documenting
  • I have made corresponding changes to the documentation
  • I have added any appropriate tests

@jonathanlam jonathanlam enabled auto-merge January 20, 2025 01:01
@jonathanlam jonathanlam added the minor Minor version updates (features) label Jan 20, 2025
@jonathanlam jonathanlam merged commit 36a6881 into main Jan 20, 2025
21 of 22 checks passed
@jonathanlam jonathanlam deleted the add-Type-to-distinguish-gitlab-DiffNote-and-DiscussionNote branch January 20, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor version updates (features)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants