Fix UriFormatException (#921)

* Fix UriFormatException Fix UriFormatException with message "Invalid URI: Invalid port specified." when Username contains '@' * Handle null username Co-authored-by: Stuart Lang <[email protected]>
NuKeeperDotNet · Feb 17, 2020 · 7f8fa17 · 7f8fa17
1 parent f6d9a82
commit 7f8fa17
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/NuKeeper.Git/GitCmdDriver.cs b/NuKeeper.Git/GitCmdDriver.cs
@@ -95,12 +95,12 @@ private  async Task<string> StartGitProzess(string arguments, bool ensureSuccess
 
         private Uri CreateCredentialsUri(Uri pullEndpoint, GitUsernamePasswordCredentials gitCredentials)
         {
-            if (_gitCredentials == null)
+            if (_gitCredentials?.Username == null)
             {
                 return pullEndpoint;
             }
 
-            return new UriBuilder(pullEndpoint) { UserName = gitCredentials.Username, Password = gitCredentials.Password }.Uri;
+            return new UriBuilder(pullEndpoint) { UserName = Uri.EscapeDataString(gitCredentials.Username), Password = gitCredentials.Password }.Uri;
         }
     }
 }