Hotfix: stats total download counts overflow

NuGet · Feb 15, 2017 · ada7125 · ada7125
1 parent dde504d
commit ada7125
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Stats.CreateAzureCdnWarehouseReports/GalleryTotalsReport.cs b/src/Stats.CreateAzureCdnWarehouseReports/GalleryTotalsReport.cs
@@ -46,7 +46,7 @@ public async Task Run()
             using (var connection = await StatisticsDatabase.ConnectTo())
             using (var transaction = connection.BeginTransaction(IsolationLevel.Snapshot))
             {
-                totalsData.Downloads = (await connection.ExecuteScalarWithRetryAsync<int>(
+                totalsData.Downloads = (await connection.ExecuteScalarWithRetryAsync<long>(
                     WarehouseStoredProcedureName, commandType: CommandType.StoredProcedure, transaction: transaction));
             }
             Trace.TraceInformation("Total downloads: {0}", totalsData.Downloads);

diff --git a/src/Stats.Warehouse/Programmability/Stored Procedures/dbo.SelectTotalDownloadCounts.sql b/src/Stats.Warehouse/Programmability/Stored Procedures/dbo.SelectTotalDownloadCounts.sql
@@ -4,6 +4,6 @@ BEGIN
 	SET NOCOUNT ON;
 
 	-- select total # of downloads + correction for packages that can not be mapped
-	SELECT	SUM(ISNULL(F.[DownloadCount], 0)) - 21000000 AS [Downloads]
+	SELECT	SUM(CAST(ISNULL(F.[DownloadCount], 0) AS BIGINT)) - 21000000 AS [Downloads]
 	FROM	[dbo].[Fact_Download] (NOLOCK) AS F
 END