-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add space before year in incollection #4
Add space before year in incollection #4
Conversation
I don't see anything wrong with this, but could you add an incollection item to the tests? That way we can make sure it is correct for the future too. |
Certainly! I was about to, but I guess I got lazy ;D |
There are some other issues with years that I'm not sure how to address (and issues seem to be disabled for this repo?):
|
Ah, no, |
Hi @mlhetland I enabled issues if you want to put the issue there. I believe I just forked the original repo because it wasn't working with newer versions of BibLaTeX. So, I didn't have the expectation that I would start collecting changes. :-) Anyway, I'll look a bit closer at these later today. |
Indeed! Well, I'm not sure where these efforts are best directed, but your fork seemed more active/responsive (as is also pointed out by an issue at latextemplates), which is why I added some PRs here :-) |
LGTM. Thank you. |
Just following the pattern for similar drivers.