Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#625 Migrate to Node 18 #1288

Merged
merged 5 commits into from
Aug 21, 2023
Merged

#625 Migrate to Node 18 #1288

merged 5 commits into from
Aug 21, 2023

Conversation

acd124
Copy link
Contributor

@acd124 acd124 commented Aug 16, 2023

Changes

Migration to Vite done with #619
Other minor errors noticed in research are included in this PR

To Do

Any remaining things that need to get done

  • Test production deployment with node 18
  • Test GitHub flow with node 18

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #625

@acd124 acd124 self-assigned this Aug 16, 2023
@acd124 acd124 requested review from anthonybernardi and removed request for anthonybernardi August 17, 2023 00:03
@RChandler234 RChandler234 self-requested a review August 17, 2023 00:06
Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the package.json's for the frontend, shared, and backend are all using different versions of @types/node can you see if you can upgrade those as well while you're doing this

@acd124
Copy link
Contributor Author

acd124 commented Aug 19, 2023

the package.json's for the frontend, shared, and backend are all using different versions of @types/node can you see if you can upgrade those as well while you're doing this

done

@RChandler234 RChandler234 merged commit 5c87627 into develop Aug 21, 2023
@RChandler234 RChandler234 deleted the #625-node-18-cleanup branch August 21, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevOps] - Migrate to Node 18
2 participants