This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
Feature/ble gap device name set #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SEC_MODE_SET methods to BLEGapConnSecMode
|
Please note that this pull request is using commits also in #188 |
jornbh
suggested changes
Jun 30, 2022
pc_ble_driver_py/ble_driver.py
Outdated
Comment on lines
2288
to
2289
| write_perm.sm = 0 | ||
| write_perm.lv = 0 |
There was a problem hiding this comment.
This should probably be .set_no_access()
pc_ble_driver_py/ble_driver.py
Outdated
Comment on lines
2291
to
2292
| write_perm.sm = 1 | ||
| write_perm.lv = 1 |
There was a problem hiding this comment.
Ok! Now using the BLEGapConnSecMode methods for setting write permissions for the name.
Also trying to write a test for ble_gap_device_name_set()
Also, start writing a test for ble_gap_device_name_set()
jornbh
suggested changes
Jul 4, 2022
Comment on lines
+181
to
+184
| def test_ble_gap_device_name_set(): | ||
| ble_tester.driver.ble_gap_device_name_set(name="Name 1") | ||
|
|
||
| ble_tester.driver.ble_gap_device_name_set(name="Name 2", device_name_read_only=False) |
There was a problem hiding this comment.
This is good, but there is no way to test if the value you tried to set actually was set as well. You may need expose the corresponding get-function "ble_gap_device_name_get", as well as the set-function you already have exposed.
There was a problem hiding this comment.
Writing and then checking two different names to the same device should be sufficient.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch aiming to fix the issue discussed in this thread:
https://devzone.nordicsemi.com/f/nordic-q-a/71774/device-name-shows-garbage-using-pc_ble_driver_py
Example code:
Setting a read-only device name:
Setting a writable device name: