Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Add libffi7 for python 3.8 support #92

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add libffi7 for python 3.8 support #92

merged 3 commits into from
Jan 11, 2024

Conversation

Himel55
Copy link
Contributor

@Himel55 Himel55 commented Jan 9, 2024

The zephyr test runner twister fails because the ctypes dependency requires libffi7 when using python 3.8 (the version of python installed by the toolchain manager).

@coderbyheart
Copy link
Member

Please add a test that shows that the change fixes the problem.

@Himel55
Copy link
Contributor Author

Himel55 commented Jan 9, 2024

Updated with a test. This is what I was getting before the change:
image

@Himel55
Copy link
Contributor Author

Himel55 commented Jan 10, 2024

not sure why but the CI seems to be failing on the downloading of the toolchain bundle

@coderbyheart
Copy link
Member

Yeah, this regularly happens.

@Himel55
Copy link
Contributor Author

Himel55 commented Jan 11, 2024

Is it possible to re-run a variant?

@coderbyheart
Copy link
Member

Rerunning them now.

@coderbyheart coderbyheart merged commit 000081f into NordicPlayground:saga Jan 11, 2024
8 checks passed
@coderbyheart
Copy link
Member

Thank you!

@Himel55 Himel55 deleted the feature/add_ffi_support branch January 11, 2024 20:31
@Himel55
Copy link
Contributor Author

Himel55 commented Jan 11, 2024

Thanks!

@coderbyheart
Copy link
Member

@Himel55 the most recent version of Twister no longer works. Do you have an idea how to fix this?

@Himel55
Copy link
Contributor Author

Himel55 commented Oct 21, 2024

Looks like the match statement was used in one of the twister library files which isn't supported in python 3.8. This has been fixed upstream by zephyr here - (zephyrproject-rtos/zephyr@4cc3134)

But the nordic fork of zephyr doesn't include this change yet - https://github.com/nrfconnect/sdk-zephyr/commits/main/scripts/pylib/twister/twisterlib/statuses.py

@coderbyheart
Copy link
Member

Ah cool, thanks for the info ... we'll just wait then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants