Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLL-5772 handle upnp lease expiry when battery optimizations are on #948

Conversation

tomaszklak
Copy link
Contributor

@tomaszklak tomaszklak commented Nov 14, 2024

Problem

UPNP lease is not renewed when battery optimizations are turned on and UPNP endpoint provider is paused.

Solution

Ignore battery optimizations when it't time (at least 75% of the whole lease duration) to renew the lease.

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@tomaszklak tomaszklak requested a review from a team as a code owner November 14, 2024 17:37
@tomaszklak tomaszklak changed the title Llt 5772 handle upnp lease expiry when battery optimizations are on LLL-5772 handle upnp lease expiry when battery optimizations are on Nov 14, 2024
Copy link
Contributor

@dfetti dfetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0

@tomaszklak tomaszklak force-pushed the LLT-5772-handle-upnp-lease-expiry-when-battery-optimizations-are-on branch from b92ad77 to a09030b Compare November 26, 2024 10:27
After we reach 75% of the lease duration, even if the optimizations are
enabled, we should enter the noraml select! section of the Task loop.
This enables upnp code to notice the need for renew and issue mapping
request.
Logs are now stored in /var/log/linux-igd.log on each of the upnp
gateways.
@tomaszklak tomaszklak force-pushed the LLT-5772-handle-upnp-lease-expiry-when-battery-optimizations-are-on branch from a09030b to 8f685ee Compare November 26, 2024 10:31
Copy link
Contributor

@Jauler Jauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0

@tomaszklak tomaszklak merged commit b2a2d38 into main Nov 29, 2024
63 checks passed
@tomaszklak tomaszklak deleted the LLT-5772-handle-upnp-lease-expiry-when-battery-optimizations-are-on branch November 29, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants