Increase constrains in link state testcases #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfetti
force-pushed
the
LLT-5683-increase-constranins-in-link-state-testcases
branch
from
e02a96d to
4b5ef12
Compare
dfetti
force-pushed
the
LLT-5683-increase-constranins-in-link-state-testcases
branch
from
4b5ef12 to
c1193b5
Compare
dfetti
force-pushed
the
LLT-5683-increase-constranins-in-link-state-testcases
branch
from
c1193b5 to
e93f34c
Compare
dfetti
force-pushed
the
LLT-5683-increase-constranins-in-link-state-testcases
branch
from
e93f34c to
0ab9458
Compare
dfetti
force-pushed
the
LLT-5683-increase-constranins-in-link-state-testcases
branch
from
0ab9458 to
8aaa4d9
Compare
Comment on lines
+153
to
+159
| await client_alpha.wait_for_link_state(beta.public_key, [LinkState.UP]) | ||
| await client_beta.wait_for_link_state(alpha.public_key, [LinkState.UP]) |
There was a problem hiding this comment.
These can be executed in parallel as if alpha will emit link state event sooner, say at t=0 and at t=10 beta emits, then alpha will be delayed.
This doesn't pose a problem if we just need the fact that both emitted the event but in this case we should retrieve the timestamps when they received those events and adjust accordingly since there might be a huge difference and interfere with test results
Previously the link state testcase scenarios were structured like setup, do some interaction between peers, sleep for a while and check the reported link states. This approach did not consider the timings of the events. Proposed solution consists in checking the state constantly during the scenario, not only at the end of it. Signed-off-by: Daniel Fetti <[email protected]>
LukasPukenis
force-pushed
the
LLT-5683-increase-constranins-in-link-state-testcases
branch
from
8aaa4d9 to
e2980ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the link state testcase scenarios were structured like setup, do some interaction between peers, sleep for a while and check the reported link states. This approach did not consider the timings of the events.
Proposed solution consists in checking the state constantly during the scenario, not only at the end of it.
☑️ Definition of Done checklist