-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLT-5563] Add TLS and domain names to core-api and mqtt #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c49e59
to
9643480
Compare
9643480
to
1f8a21b
Compare
Jauler
reviewed
Oct 16, 2024
730efd3
to
eba49fb
Compare
lgtm, but I'm not an expert on python and https, so +0.5 |
gytsto
previously approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
tomaszklak
reviewed
Oct 22, 2024
tomaszklak
previously approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, nice :)
eba49fb
to
ce6b054
Compare
ce6b054
to
92a8b35
Compare
tomaszklak
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In context of esp32-meshnet nat-lab integration tests, device emulator is going to send requests to
https://api.nordvpn.com
. So far, nat-lab core-api was not supporting tls connection and core-api domain.Solution
CN=*.nordvpn.com"
record. Certificate is used for core-api as well as for mqtt broker.cone-client-01
indocker-compose.yml
. This is only for core-api and notification center tests. esp32 emulator is going to use nat-lab DNS server to resolve requested domains.mqtt.nordvpn.com
DNS records. In context of this test, it might be not so relevant as the purpose of the test is to verify mqtt messages. If there is any issue with tls connection to the mqtt-broker, it will be failing then either on docker compose level or core-api tests.☑️ Definition of Done checklist