Minimal implemenation of the notification center mqtt service #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszklak
force-pushed
the
LLT-5564-minimal-mqtt-support
branch
2 times, most recently
from
829f4c3 to
9261bac
Compare
stalowyjez
force-pushed
the
LLT-5564-minimal-mqtt-support
branch
2 times, most recently
from
0cafabd to
8c23da6
Compare
stalowyjez
force-pushed
the
LLT-5564-minimal-mqtt-support
branch
from
8c23da6 to
70e7bf1
Compare
Jauler
reviewed
Sep 19, 2024
olekoliinyk
reviewed
Sep 19, 2024
Jauler
reviewed
Sep 19, 2024
Jauler
reviewed
Sep 19, 2024
Jauler
previously approved these changes
Sep 19, 2024
There was a problem hiding this comment.
So other then https://github.com/NordSecurity/libtelio/pull/815/files#r1766348529, +1.0
stalowyjez
force-pushed
the
LLT-5564-minimal-mqtt-support
branch
from
70e7bf1 to
a29ca19
Compare
stalowyjez
force-pushed
the
LLT-5564-minimal-mqtt-support
branch
from
dee1285 to
8e1a600
Compare
stalowyjez
force-pushed
the
LLT-5564-minimal-mqtt-support
branch
from
8e1a600 to
1f9dacc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To test both the esp32/esphome and openwrt we need an environment that has a working fake of the notification center.
Solution
This adds a mqtt broker and a small fake implementation of the notification center. The http endpoints are just as an example used to manually test the fake (those will be implemented for real in LLT-5563).
☑️ Definition of Done checklist