Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLT-5552: Create teliod daemon #812

Merged
merged 10 commits into from
Sep 26, 2024
Merged

LLT-5552: Create teliod daemon #812

merged 10 commits into from
Sep 26, 2024

Conversation

stalowyjez
Copy link
Contributor

@stalowyjez stalowyjez commented Sep 9, 2024 •
edited
Loading

Problem

We need some skeleton for a new Telio daemon to be run in OpenWRT

Solution

Add a skeleton of a new Teliod daemon

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@stalowyjez stalowyjez requested a review from a team as a code owner September 9, 2024 10:37
@stalowyjez stalowyjez force-pushed the LLT-5552-create_teliod_daemon branch 7 times, most recently from e880323 to 04a36ea Compare September 9, 2024 21:22
lcruz99
lcruz99 reviewed Sep 10, 2024
View reviewed changes
lcruz99
lcruz99 reviewed Sep 10, 2024
View reviewed changes
@lcruz99
Copy link
Contributor

lcruz99 commented Sep 10, 2024 •
edited
Loading

the more I review this the more I wonder: shouldn't this be compilable? at least linters should have been run?

...and tclid gets broken with these changes

@stalowyjez stalowyjez force-pushed the LLT-5552-create_teliod_daemon branch from 04a36ea to 624de1f Compare September 10, 2024 17:35
@stalowyjez stalowyjez force-pushed the LLT-5552-create_teliod_daemon branch 8 times, most recently from dab9532 to 6fc84b1 Compare September 11, 2024 21:51
@ThrasherLT
Copy link
Contributor

+1

@stalowyjez stalowyjez force-pushed the LLT-5552-create_teliod_daemon branch from 74986c6 to 47f1c9e Compare September 23, 2024 07:56
lcruz99
lcruz99 reviewed Sep 23, 2024
View reviewed changes
Jauler
Jauler reviewed Sep 23, 2024
View reviewed changes
Jauler
Jauler reviewed Sep 23, 2024
View reviewed changes
Jauler
Jauler reviewed Sep 23, 2024
View reviewed changes
Jauler
Jauler reviewed Sep 23, 2024
View reviewed changes
Jauler
Jauler reviewed Sep 23, 2024
View reviewed changes
@stalowyjez stalowyjez force-pushed the LLT-5552-create_teliod_daemon branch 2 times, most recently from 0842fc4 to faf292a Compare September 24, 2024 15:50
Jauler
Jauler reviewed Sep 25, 2024
View reviewed changes
Jauler
Jauler reviewed Sep 25, 2024
View reviewed changes
Jauler
Jauler previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Jauler Jauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0, just I guess pid-file creation and removal is not needed anymore, so we can remove it.

@stalowyjez stalowyjez force-pushed the LLT-5552-create_teliod_daemon branch from a01e295 to 7a0af40 Compare September 25, 2024 14:27
ThrasherLT
ThrasherLT approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ThrasherLT ThrasherLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed again after changes, everything seems sorted out, so +1.0

Jauler
Jauler approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Jauler Jauler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0

@stalowyjez stalowyjez merged commit 59717c0 into main Sep 26, 2024
62 checks passed
@stalowyjez stalowyjez deleted the LLT-5552-create_teliod_daemon branch September 26, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcruz99 lcruz99 lcruz99 left review comments

@Jauler Jauler Jauler approved these changes

@ThrasherLT ThrasherLT ThrasherLT approved these changes

@jjanowsk jjanowsk Awaiting requested review from jjanowsk jjanowsk is a code owner

@packgron packgron Awaiting requested review from packgron packgron is a code owner

@tomaszklak tomaszklak Awaiting requested review from tomaszklak tomaszklak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stalowyjez @lcruz99 @ThrasherLT @Jauler